Skip to content

feat(superuser): try all bridges instead of first-match-only#22931

Open
r3m8 wants to merge 1 commit intocockpit-project:mainfrom
r3m8:superuser-bridge-fallback
Open

feat(superuser): try all bridges instead of first-match-only#22931
r3m8 wants to merge 1 commit intocockpit-project:mainfrom
r3m8:superuser-bridge-fallback

Conversation

@r3m8
Copy link

@r3m8 r3m8 commented Feb 26, 2026

#22930

This PR fixes the "first-match-wins" policy in superuser bridge selection using SuperuserRoutingRule.go() to iterate through all matching bridges in manifest order, trying each one until one succeeds. If all bridges fail, only then is access denied.

Changelog :

Enable superuser bridge fallback: try alternative bridges when first fails

Copy link
Member

@allisonkarlitskaya allisonkarlitskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reasonably certain we can't take the change in this form, sorry. Even if it works, it's not a good experience that the user is always first thrown at sudo (which we assume will fail) every time and then switched to another method without explanation. We definitely need more UI for this.

Let's discuss things further in the linked issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants