feat(superuser): try all bridges instead of first-match-only#22931
Open
r3m8 wants to merge 1 commit intocockpit-project:mainfrom
Open
feat(superuser): try all bridges instead of first-match-only#22931r3m8 wants to merge 1 commit intocockpit-project:mainfrom
r3m8 wants to merge 1 commit intocockpit-project:mainfrom
Conversation
allisonkarlitskaya
requested changes
Feb 26, 2026
Member
allisonkarlitskaya
left a comment
There was a problem hiding this comment.
I'm reasonably certain we can't take the change in this form, sorry. Even if it works, it's not a good experience that the user is always first thrown at sudo (which we assume will fail) every time and then switched to another method without explanation. We definitely need more UI for this.
Let's discuss things further in the linked issue.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22930
This PR fixes the "first-match-wins" policy in superuser bridge selection using
SuperuserRoutingRule.go()to iterate through all matching bridges in manifest order, trying each one until one succeeds. If all bridges fail, only then is access denied.Changelog :