cockpit-client: upgrade to GTK 4 & WebKit 6#22958
Open
jelly wants to merge 1 commit intocockpit-project:mainfrom
Open
cockpit-client: upgrade to GTK 4 & WebKit 6#22958jelly wants to merge 1 commit intocockpit-project:mainfrom
jelly wants to merge 1 commit intocockpit-project:mainfrom
Conversation
jelly
added
the
no-test
jelly
force-pushed
the
cockpit-client-gtk4
branch
2 times, most recently
from
26d4e5d to
80dbceb
Compare
Member
Author
|
The testing issue here is run_javascript is deprecated and no longer available in WebKit 6. |
jelly
force-pushed
the
cockpit-client-gtk4
branch
from
80dbceb to
95c747d
Compare
GTK 3 will still be supported until the release of GTK 5, moving to GTK 4 already gives us the benefit of not having to do a major upgrade directly to 5. Other side-effects of upgrading is the move to WebKit 6.0 which should bring in more modern JavaScript / CSS support. The most notable API changes are: * Sandboxing is now always enabled * Gtk.show_uri* is deprecated and replaced by by UriLauncher * The HeaderBar title now needs to be updated by the application * LibHandy is replaced by Adwaita, in GTK 4 inheriting from Adwaita is preferred https://docs.gtk.org/gtk4/migrating-3to4.html https://webkitgtk.org/reference/webkit2gtk/2.39.7/migrating-to-webkitgtk-6.0.html
jelly
force-pushed
the
cockpit-client-gtk4
branch
from
95c747d to
6661777
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GTK 3 will still be supported until the release of GTK 5, moving to GTK 4 already gives us the benefit of not having to do a major upgrade directly to 5. Other side-effects of upgrading is the move to WebKit 6.0 which should bring in more modern JavaScript / CSS support.
The most notable API changes are:
https://docs.gtk.org/gtk4/migrating-3to4.html
https://webkitgtk.org/reference/webkit2gtk/2.39.7/migrating-to-webkitgtk-6.0.html
Locally test this and it seems to work fine, remember that you can locally build the flatpak with
./containers/flatpak/install --user.