chore: faster referential integrity for tests #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuonOmo
force-pushed
the
faster-ref-integrity
branch
4 times, most recently
from
0e5baae to
945c57c
Compare
BuonOmo
force-pushed
the
faster-ref-integrity
branch
from
945c57c to
6afe199
Compare
BuonOmo
commented
Jan 6, 2025
|
|
||
| # This overrides the method from PostegreSQL adapter | ||
| # Resets the sequence of a table's primary key to the maximum value. | ||
| def reset_pk_sequence!(table, pk = nil, sequence = nil) |
Collaborator
Author
There was a problem hiding this comment.
the difference lied in a condition database_version < 10, which will never be true in our codebase!
BuonOmo
commented
Jan 6, 2025
| options[:deferrable] = extract_constraint_deferrable(row["deferrable"], row["deferred"]) | ||
|
|
||
| options[:validate] = row["valid"] | ||
| to_table = PostgreSQL::Utils.unquote_identifier(row["to_table"]) |
Collaborator
Author
There was a problem hiding this comment.
already done a few lines ago
BuonOmo
commented
Jan 6, 2025
| # Normally, the primary keys would use CockroachDB's unique_rowid(). | ||
| def test_create_symbol_fixtures | ||
| fixtures = ActiveRecord::FixtureSet.create_fixtures(FIXTURES_ROOT, :collections, collections: Course) { Course.lease_connection } | ||
| fixtures = ActiveRecord::FixtureSet.create_fixtures(FIXTURES_ROOT, :collections, collections: Course) |
Collaborator
Author
There was a problem hiding this comment.
mimicking upstream change
rafiss
approved these changes
Jan 6, 2025
Contributor
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
This is a really great speedup, thank you! Also, the new debugging functions look very useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance of the
#disable_referential_integrityby fetching every foreign keys at once. This method is where most time is spent in tests, hence this PR helps dividing by 3 our test suite time.