Speedup tests #361
Merged
Speedup tests #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafiss
approved these changes
Jan 10, 2025
| # Cockroachdb ignores the UNLOGGED specifier. | ||
| # https://github.com/cockroachdb/cockroach/issues/56827 | ||
| def test_unlogged_in_test_environment_when_unlogged_setting_enabled | ||
| @original_create_unlogged_tables = ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.create_unlogged_tables |
Contributor
There was a problem hiding this comment.
unfortunately, UNLOGGED does not have any effect in CRDB, but the rest of this change does seem helpful. thanks!
https://www.cockroachlabs.com/docs/stable/create-table#parameters
Collaborator
Author
There was a problem hiding this comment.
Ok so maybe I'll just remove unlogged related tests and configurations!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the lead of rails/rails#47499 we ensure tables are always unlogged, and we dump only necessary parts of the schema. This should gain ~7mn