Added Support for Termination Grace Period in crdbcluster #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NishanthNalluri
commented
Jan 28, 2025
NishanthNalluri
commented
- To Address [CRDB-43619] we have made Termination Grace Period a customizable field in crdbcluster CR
- If nothing is specified as a part of CR Termination Grace Period for each pod defaults to 300
Removed rules_k8s bazel dependency as it is deprecated and not supported with rules_oci.
Member
|
|
pritesh-lahoti
approved these changes
Jan 29, 2025
prafull01
approved these changes
Jan 29, 2025
pritesh-lahoti
approved these changes
Feb 3, 2025
Contributor
Author
|
fixes #1055 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.