Skip to content

Conversation

@prafull01
Copy link
Contributor

No description provided.

@prafull01 prafull01 force-pushed the update-dependencies branch 2 times, most recently from fc8ee2f to 16526b6 Compare June 17, 2025 07:14
@prafull01 prafull01 force-pushed the update-dependencies branch 3 times, most recently from 8c015d3 to a4f9d71 Compare June 17, 2025 11:29
@prafull01 prafull01 requested a review from Copilot June 17, 2025 11:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to use Kubernetes v1.30 and controller-runtime v0.18, updating API calls, client creation, and related build and dependency configurations.

  • Updates clientset creation functions to use NewForConfigAndClient for shared HTTP client usage.
  • Modifies webhook and defaulting/validation interfaces to align with controller-runtime v0.18 changes.
  • Updates project dependencies, code generation scripts, and Bazel/workspace configurations.

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/client/clientset/versioned/clientset.go Updated clientset creation using NewForConfigAndClient to share HTTP client transport.
pkg/actor/initialize.go Added context parameter to ExecInPod call as per updated API.
pkg/actor/director_test.go Updated test expectations for new API changes in StatefulSet spec and resource definitions.
hack/verify-crds.sh Revised CRD generation arguments per updated controller-runtime requirements.
hack/update-codegen.sh Adjusted flags and output file naming conventions for code generators.
cmd/cockroach-operator/main.go Refactored manager options to align with new multi-namespace and webhook server configuration.
apis/v1alpha1/webhook*.go Updated webhook interfaces to the CustomDefaulter/CustomValidator patterns with context.
Other files (BUILD.bazel, WORKSPACE, Makefile, etc.) Updated dependency versions, build rules, and miscellaneous configurations.
Comments suppressed due to low confidence (2)

cmd/cockroach-operator/main.go:118

  • Verify that replacing MultiNamespacedCacheBuilder with cache.New properly supports multi-namespace caching and provides equivalent behavior in multi-tenant environments.
mgrOpts.NewCache = cache.New

hack/update-codegen.sh:115

  • Ensure downstream build scripts and code references are updated to accommodate the change in the generated deepcopy file name for consistency across the codebase.
--output-file zz_generated.deepcopy.go

@prafull01 prafull01 force-pushed the update-dependencies branch from b0c7ed2 to 18b631b Compare June 17, 2025 15:24
@prafull01 prafull01 merged commit 5a36c88 into cockroachdb:master Jun 18, 2025
8 checks passed
@prafull01 prafull01 deleted the update-dependencies branch June 18, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants