Update the kubernetes to v1.30 and controller runtime to v0.18#1112
Merged
prafull01 merged 1 commit intocockroachdb:masterfrom Jun 18, 2025
Merged
Update the kubernetes to v1.30 and controller runtime to v0.18#1112prafull01 merged 1 commit intocockroachdb:masterfrom
prafull01 merged 1 commit intocockroachdb:masterfrom
Conversation
fc8ee2f to
16526b6
Compare
8c015d3 to
a4f9d71
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to use Kubernetes v1.30 and controller-runtime v0.18, updating API calls, client creation, and related build and dependency configurations.
- Updates clientset creation functions to use NewForConfigAndClient for shared HTTP client usage.
- Modifies webhook and defaulting/validation interfaces to align with controller-runtime v0.18 changes.
- Updates project dependencies, code generation scripts, and Bazel/workspace configurations.
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/client/clientset/versioned/clientset.go | Updated clientset creation using NewForConfigAndClient to share HTTP client transport. |
| pkg/actor/initialize.go | Added context parameter to ExecInPod call as per updated API. |
| pkg/actor/director_test.go | Updated test expectations for new API changes in StatefulSet spec and resource definitions. |
| hack/verify-crds.sh | Revised CRD generation arguments per updated controller-runtime requirements. |
| hack/update-codegen.sh | Adjusted flags and output file naming conventions for code generators. |
| cmd/cockroach-operator/main.go | Refactored manager options to align with new multi-namespace and webhook server configuration. |
| apis/v1alpha1/webhook*.go | Updated webhook interfaces to the CustomDefaulter/CustomValidator patterns with context. |
| Other files (BUILD.bazel, WORKSPACE, Makefile, etc.) | Updated dependency versions, build rules, and miscellaneous configurations. |
Comments suppressed due to low confidence (2)
cmd/cockroach-operator/main.go:118
- Verify that replacing MultiNamespacedCacheBuilder with cache.New properly supports multi-namespace caching and provides equivalent behavior in multi-tenant environments.
mgrOpts.NewCache = cache.New
hack/update-codegen.sh:115
- Ensure downstream build scripts and code references are updated to accommodate the change in the generated deepcopy file name for consistency across the codebase.
--output-file zz_generated.deepcopy.go
a4f9d71 to
b0c7ed2
Compare
b0c7ed2 to
18b631b
Compare
pritesh-lahoti
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.