Skip to content

Commit 0e24e97

Browse files
wenyihu6tbg
authored andcommitted
asim: sue DefaultSpanConfigWithRF in more places
Previously, we added DefaultSpanConfigWithRF as a helper function. This commit makes use of it at more places. Epic: none Release note: none
1 parent 1edba4a commit 0e24e97

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

pkg/kv/kvserver/asim/state/new_state.go

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -297,13 +297,9 @@ func RangesInfoWithReplicaCounts(
297297
distribution := exactDistribution(counts)
298298
storeList := makeStoreList(stores)
299299

300-
spanConfig := defaultSpanConfig
301-
spanConfig.NumReplicas = int32(replicationFactor)
302-
spanConfig.NumVoters = int32(replicationFactor)
303-
304300
return RangesInfoWithDistribution(
305-
storeList, distribution, distribution, ranges, spanConfig,
306-
int64(MinKey), int64(keyspace), rangeSize)
301+
storeList, distribution, distribution, ranges,
302+
DefaultSpanConfigWithRF(replicationFactor), int64(MinKey), int64(keyspace), rangeSize)
307303
}
308304

309305
func RangesInfoEvenDistribution(
@@ -332,15 +328,12 @@ func RangesInfoWeightedRandDistribution(
332328
}
333329
distribution := weightedRandDistribution(randSource, weightedStores)
334330
storeList := makeStoreList(len(weightedStores))
335-
spanConfig := defaultSpanConfig
336-
spanConfig.NumReplicas = int32(replicationFactor)
337-
spanConfig.NumVoters = int32(replicationFactor)
338331
return RangesInfoWithDistribution(
339332
storeList,
340333
distribution,
341334
distribution,
342335
ranges,
343-
spanConfig,
336+
DefaultSpanConfigWithRF(replicationFactor),
344337
minKey, maxKey,
345338
rangeSize,
346339
)
@@ -367,6 +360,6 @@ func RangesInfoRandDistribution(
367360
spanConfig.NumVoters = int32(replicationFactor)
368361

369362
return RangesInfoWithDistribution(
370-
storeList, distribution, distribution, ranges, spanConfig,
363+
storeList, distribution, distribution, ranges, DefaultSpanConfigWithRF(replicationFactor),
371364
minKey, maxKey, rangeSize)
372365
}

pkg/kv/kvserver/asim/state/new_state_test_helper.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ func NewStateWithDistribution(
4242
percentOfReplicas,
4343
percentOfReplicas,
4444
ranges,
45-
spanConfig,
45+
DefaultSpanConfigWithRF(replicationFactor),
4646
int64(MinKey),
4747
int64(keyspace),
4848
0, /* rangeSize */

0 commit comments

Comments
 (0)