asim: remove unused keyspace for rand testing

Previously, we added min/max key with staticOptionSettings, making keyspace
unused. This commit finishes the cleanup by removing the unused keyspace field.

Epic: none
Release note: none

Author: wenyihu6

pkg/kv/kvserver/asim/tests/default_settings.go

@@ -19,12 +19,10 @@ const (
 	defaultStoresPerNode = 1
 )
 
-const defaultKeyspace = 200000
-
 const (
 	defaultRwRatio, defaultRate      = 0.0, 0.0
 	defaultMinBlock, defaultMaxBlock = 1, 1
-	defaultMinKey, defaultMaxKey     = int64(0), int64(defaultKeyspace)
+	defaultMinKey, defaultMaxKey     = int64(0), int64(200000)
 	defaultSkewedAccess              = false
 )
 
@@ -51,7 +49,6 @@ type staticOptionSettings struct {
 	maxKey            int64
 	skewedAccess      bool
 	ranges            int
-	keySpace          int
 	placementType     gen.PlacementType
 	replicationFactor int
 	bytes             int64
@@ -72,7 +69,6 @@ func getDefaultStaticOptionSettings() staticOptionSettings {
 		maxKey:            defaultMaxKey,
 		skewedAccess:      defaultSkewedAccess,
 		ranges:            defaultRanges,
-		keySpace:          defaultKeyspace,
 		placementType:     defaultPlacementType,
 		replicationFactor: defaultReplicationFactor,
 		bytes:             defaultBytes,

pkg/kv/kvserver/asim/tests/output.go

@@ -104,8 +104,8 @@ func printTestSettings(t testSettings, staticSettings staticOptionSettings, buf
 		buf.WriteString(fmt.Sprintf("\t%v\n", t.rangeGen))
 	} else {
 		buf.WriteString(configStr("ranges", "static"))
-		buf.WriteString(fmt.Sprintf("\tplacement_type=%v, ranges=%d, key_space=%d, replication_factor=%d, bytes=%d\n",
-			staticSettings.placementType, staticSettings.ranges, staticSettings.keySpace, staticSettings.replicationFactor, staticSettings.bytes))
+		buf.WriteString(fmt.Sprintf("\tplacement_type=%v, ranges=%d, min_key=%d, max_key=%d, replication_factor=%d, bytes=%d\n",
+			staticSettings.placementType, staticSettings.ranges, staticSettings.minKey, staticSettings.maxKey, staticSettings.replicationFactor, staticSettings.bytes))
 	}
 
 	if t.randOptions.load {

pkg/kv/kvserver/asim/tests/rand_test.go

@@ -194,7 +194,6 @@ func TestRandomized(t *testing.T) {
 				scanIfExists(t, d, "max_key", &staticOptionSettings.maxKey)
 				scanIfExists(t, d, "skewed_access", &staticOptionSettings.skewedAccess)
 				scanIfExists(t, d, "ranges", &staticOptionSettings.ranges)
-				scanIfExists(t, d, "key_space", &staticOptionSettings.keySpace)
 				scanIfExists(t, d, "placement_type", &staticOptionSettings.placementType)
 				scanIfExists(t, d, "replication_factor", &staticOptionSettings.replicationFactor)
 				scanIfExists(t, d, "bytes", &staticOptionSettings.bytes)

pkg/kv/kvserver/asim/tests/testdata/rand/default_settings

@@ -47,7 +47,7 @@ test settings
 generating cluster configurations using static option
 	nodes=3, stores_per_node=1
 generating ranges configurations using static option
-	placement_type=even, ranges=10, key_space=200000, replication_factor=3, bytes=0
+	placement_type=even, ranges=10, min_key=0, max_key=200000, replication_factor=3, bytes=0
 generating load configurations using static option
 	rw_ratio=0.00, rate=0.00, min_block=1, max_block=1, min_key=0, max_key=200000, skewed_access=false
 generating events configurations using static option
@@ -163,7 +163,7 @@ test settings
 generating cluster configurations using static option
 	nodes=3, stores_per_node=1
 generating ranges configurations using static option
-	placement_type=even, ranges=10, key_space=200000, replication_factor=3, bytes=0
+	placement_type=even, ranges=10, min_key=0, max_key=200000, replication_factor=3, bytes=0
 generating load configurations using static option
 	rw_ratio=0.00, rate=0.00, min_block=1, max_block=1, min_key=0, max_key=200000, skewed_access=false
 generating events configurations using static option
@@ -213,7 +213,7 @@ test settings
 generating cluster configurations using static option
 	nodes=3, stores_per_node=1
 generating ranges configurations using static option
-	placement_type=even, ranges=10, key_space=200000, replication_factor=3, bytes=0
+	placement_type=even, ranges=10, min_key=0, max_key=200000, replication_factor=3, bytes=0
 generating load configurations using static option
 	rw_ratio=0.00, rate=0.00, min_block=1, max_block=1, min_key=0, max_key=200000, skewed_access=false
 generating events configurations using static option
@@ -281,7 +281,7 @@ test settings
 generating cluster configurations using static option
 	nodes=5, stores_per_node=5
 generating ranges configurations using static option
-	placement_type=skewed, ranges=2, key_space=30000, replication_factor=5, bytes=2
+	placement_type=skewed, ranges=2, min_key=0, max_key=10000, replication_factor=5, bytes=2
 generating load configurations using static option
 	rw_ratio=0.20, rate=0.01, min_block=2, max_block=3, min_key=0, max_key=10000, skewed_access=true
 generating events configurations using static option

pkg/kv/kvserver/asim/tests/testdata/rand/rand_cluster

@@ -51,7 +51,7 @@ test settings
 generating cluster configurations using randomized option
 	cluster_gen_type=multi_region
 generating ranges configurations using static option
-	placement_type=even, ranges=10, key_space=200000, replication_factor=3, bytes=0
+	placement_type=even, ranges=10, min_key=0, max_key=200000, replication_factor=3, bytes=0
 generating load configurations using static option
 	rw_ratio=0.00, rate=0.00, min_block=1, max_block=1, min_key=0, max_key=200000, skewed_access=false
 generating events configurations using static option

pkg/kv/kvserver/asim/tests/testdata/rand/rand_event

@@ -15,7 +15,7 @@ test settings
 generating cluster configurations using randomized option
 	cluster_gen_type=multi_region
 generating ranges configurations using static option
-	placement_type=even, ranges=1, key_space=200000, replication_factor=3, bytes=0
+	placement_type=even, ranges=1, min_key=0, max_key=200000, replication_factor=3, bytes=0
 generating load configurations using static option
 	rw_ratio=0.00, rate=0.00, min_block=1, max_block=1, min_key=0, max_key=200000, skewed_access=false
 generating events configurations using randomized option