Skip to content

Commit 1dfa255

Browse files
craig[bot]souravcrl
andcommitted
Merge #149416
149416: logictest: fix user logictest for provisioning gating validation r=rafiss a=souravcrl The current logictest validates the version gating logic for provisioning but checks for skipif version instead of onlyif version config which was pointed out in the discussion #149405 (comment) and needs to change. Additionally, we need to add a comment for version gating logic as both are failure scenarios owing to "cert-password" currently being a non support provisioning auth method as in the discussion #149405 (comment). fixes #147599 Epic CRDB-21590 Release note: None Co-authored-by: souravcrl <[email protected]>
2 parents fdbf0be + 70b2d0f commit 1dfa255

File tree

1 file changed

+7
-3
lines changed
  • pkg/sql/logictest/testdata/logic_test

1 file changed

+7
-3
lines changed

pkg/sql/logictest/testdata/logic_test/user

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,14 +236,13 @@ user root
236236
statement ok
237237
set cluster setting security.provisioning.ldap.enabled = true;
238238

239-
skipif config local 3node-tenant
239+
onlyif config local-mixed-25.2
240240
statement ok
241241
DROP user testuser
242242

243-
skipif config local 3node-tenant
243+
onlyif config local-mixed-25.2
244244
user testuser nodeidx=0 newsession
245245

246-
skipif config local 3node-tenant
247246
statement error pq: password authentication failed for user testuser
248247
SHOW session_user
249248

@@ -263,6 +262,11 @@ DROP user testuser
263262
skipif config local-mixed-25.2
264263
user testuser nodeidx=0 newsession
265264

265+
# The logictest suite currently doesn't work for external authentication methods
266+
# as the register auth method for "ldap" is invoked outside of the sql package.
267+
# For the purpose of validating the release flags for provisioning, test only
268+
# auth method "cert-password" has been enabled which hasn't been provided with a
269+
# provisioner(handler for provisioning) which is the obtained error here.
266270
skipif config local-mixed-25.2
267271
statement error pq: user identity unknown for identity provider
268272
SHOW session_user

0 commit comments

Comments
 (0)