Skip to content

Commit 7839924

Browse files
committed
asim: add replace = true to example_splitting
Previously, we added a replace option to gen_load in data driven tests to control whether the load generator is replaced or appended. The new default is replace = false (append) which changed the original behaviour of replacing the generator. This test expected the original behavior when re-running eval, but we forgot to explicitly set replace = true. This commit fixes that. Epic: none Release note: none
1 parent 9e36b27 commit 7839924

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_splitting.txt

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ last store values: [s1=6] (stddev=0.00, mean=6.00, sum=6)
5454
# repeatedly - if the load split algorithm is good, we should expect the same
5555
# number of splits as the uniform workload. However, that is not the case as we
5656
# require more splits with a zipfian distribution.
57-
gen_load rate=10000 rw_ratio=1 access_skew=true
57+
gen_load rate=10000 rw_ratio=1 access_skew=true replace=true
5858
----
5959

6060
eval duration=5m samples=2 seed=42
@@ -63,24 +63,24 @@ OK
6363

6464
plot stat=replicas sample=4
6565
----
66-
15.00 ┤ ──────────────────────────────────────────────
67-
14.07 ╭──╯
68-
13.13 ┤ ╭───╯
69-
12.20╭──╯
70-
11.27 ┤ ╭──╯
71-
10.33 ┤ ╭──╯
72-
9.40 ┤ ╭───╯
73-
8.47╭──╯
74-
7.53
75-
6.60
76-
5.67 ┤ │
77-
4.73
78-
3.80╭──╯
79-
2.87
80-
1.93╭──╯
81-
1.00 ┼───╯
82-
replicas
66+
9.00 ┤ ╭────────────────────────────────────────────────────
67+
8.47
68+
7.93 ┤ ╭───╯
69+
7.40
70+
6.87 ┤ ╭──╯
71+
6.33 ┤
72+
5.80 ┤ ╭───╯
73+
5.27
74+
4.73 ╭──╯
75+
4.20╭──╯
76+
3.67 ┤ │
77+
3.13╭──╯
78+
2.60
79+
2.07╭──╯
80+
1.53
81+
1.00 ┼───╯
82+
replicas
8383
initial store values: [s1=1] (stddev=0.00, mean=1.00, sum=1)
84-
last store values: [s1=15] (stddev=0.00, mean=15.00, sum=15)
84+
last store values: [s1=9] (stddev=0.00, mean=9.00, sum=9)
8585

8686
# vim:ft=sh

0 commit comments

Comments
 (0)