Merge #148539 #149096 #150149 #150213 #150250 #150255

148539: sql: add storage param for region column inference r=michae2,rafiss,yuzefovich a=DrewKimball

#### sql: add storage param for region column inference

This commit adds a new storage parameter to the table descriptor
`infer_rbr_region_col_using_constraint`. It will be used by following
commits/PRs to determine a foreign-key constraint that will be used
to look up values for the RBR region column from the FK parent table.

Informs #148243

Release note: None

#### sql: implement new storage param in the schema changer

This commit implements the schema-change and validation logic for the
new storage param for region-column inference. This involves looking up
the referenced FK constraint on the table descriptor, and ensuring it
has the correct columns, as well as that the locality is RBR and no
computed columns reference the region column. This commit also adds
a set of logic tests for the process of setting and unsetting the
new storage param, without yet testing the (currently unimplemented)
functionality.

Informs #148243

Release note: None

149096: sql: use friendly schema changes status messages r=yuzefovich a=bghal

Previously the job status message provided limited information.
It required knowledge of the schema change architecture to be
actionable.
The status message is expanded to be more user-friendly.

Fixes: #125560
Epic: CRDB-42485

Release note (sql change): Schema change job status messages provide
additional information.


150149: roachtest: increase restore timeouts for fingerprinting r=yuzefovich a=kev-cao

Since validating fingerprints is now the default behavior for restore roachtests, we are seeing some test timeouts across the suite. This commit increases the timeout to account for any fingerprints on all of our restores.

Fixes: #149771

Release note: None

150213: sql: include write buffering info to EXPLAIN ANALYZE top level r=yuzefovich a=yuzefovich

In order to make it easier to notice that write buffering is enabled, we now will include top-level `write buffering enabled` message to the output of EXPLAIN ANALYZE when write buffering is enabled for all mutations as well as read-only stmts that are part of explicit txns.

Touches: #150212.
Epic: None

Release note: None

150250: storage: disable value separation by default r=yuzefovich a=annrpom

We disable value separation for now until we root
cause #150216.

Epic: none
Release note: None

150255: sql/schemachanger: properly discard zone configs for sequences r=yuzefovich a=spilchen

Discarding zone configs via the declarative schema changer was a no-op for sequences, leaving stale configs. This was due to not loading scpb.TableZoneConfig elements for sequences.

This change ensures those elements are loaded, so configs are properly removed.

Fixes #150252

Epic: none
Release note (bug fix): Fixes an issue where discarding zone configs on sequences did not remove the actual configuration.

Co-authored-by: Drew Kimball <[email protected]>
Co-authored-by: Brendan Gerrity <[email protected]>
Co-authored-by: Kevin Cao <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Annie Pompa <[email protected]>
Co-authored-by: Matt Spilchen <[email protected]>

Author: 7 people

docs/generated/settings/settings-for-tenants.txt

@@ -73,6 +73,7 @@ feature.backup.enabled	boolean	true	set to true to enable backups, false to disa
 feature.changefeed.enabled	boolean	true	set to true to enable changefeeds, false to disable; default is true	application
 feature.export.enabled	boolean	true	set to true to enable exports, false to disable; default is true	application
 feature.import.enabled	boolean	true	set to true to enable imports, false to disable; default is true	application
+feature.infer_rbr_region_col_using_constraint.enabled	boolean	false	set to true to enable looking up the region column via a foreign key constraint in a REGIONAL BY ROW table, false to disable; default is false	application
 feature.restore.enabled	boolean	true	set to true to enable restore, false to disable; default is true	application
 feature.schema_change.enabled	boolean	true	set to true to enable schema changes, false to disable; default is true	application
 feature.stats.enabled	boolean	true	set to true to enable CREATE STATISTICS/ANALYZE, false to disable; default is true	application

docs/generated/settings/settings.html

@@ -78,6 +78,7 @@
 <tr><td><div id="setting-feature-changefeed-enabled" class="anchored"><code>feature.changefeed.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable changefeeds, false to disable; default is true</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-feature-export-enabled" class="anchored"><code>feature.export.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable exports, false to disable; default is true</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-feature-import-enabled" class="anchored"><code>feature.import.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable imports, false to disable; default is true</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
+<tr><td><div id="setting-feature-infer-rbr-region-col-using-constraint-enabled" class="anchored"><code>feature.infer_rbr_region_col_using_constraint.enabled</code></div></td><td>boolean</td><td><code>false</code></td><td>set to true to enable looking up the region column via a foreign key constraint in a REGIONAL BY ROW table, false to disable; default is false</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-feature-restore-enabled" class="anchored"><code>feature.restore.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable restore, false to disable; default is true</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-feature-schema-change-enabled" class="anchored"><code>feature.schema_change.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable schema changes, false to disable; default is true</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-feature-stats-enabled" class="anchored"><code>feature.stats.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable CREATE STATISTICS/ANALYZE, false to disable; default is true</td><td>Serverless/Dedicated/Self-Hosted</td></tr>

pkg/ccl/logictestccl/testdata/logic_test/provisioning

@@ -42,4 +42,3 @@ WHERE username = 'role_with_provisioning'
 AND option = 'PROVISIONSRC'
 ----
 ldap:foo.bar
-

pkg/ccl/logictestccl/testdata/logic_test/regional_by_row

@@ -435,7 +435,7 @@ statement ok
 ALTER TABLE regional_by_row_table ADD CONSTRAINT unique_b_a UNIQUE(b, a)
 
 # Tests dropping a referenced column in REGIONAL BY ROW does not succeed.
-statement error cannot drop column crdb_region as it is used to store the region in a REGIONAL BY ROW table\nHINT: You must change the table locality before dropping this table
+statement error cannot drop column crdb_region as it is used to store the region in a REGIONAL BY ROW table\nHINT: You must change the table locality before dropping this column
 ALTER TABLE regional_by_row_table DROP COLUMN crdb_region
 
 # Tests changing the PK of a regional by row table.
@@ -619,7 +619,7 @@ pk  a     b     crdb_region_col
 20  NULL  NULL  ap-southeast-2
 
 # Tests dropping a referenced column in REGIONAL BY ROW does not succeed.
-statement error cannot drop column crdb_region_col as it is used to store the region in a REGIONAL BY ROW table\nHINT: You must change the table locality before dropping this table
+statement error cannot drop column crdb_region_col as it is used to store the region in a REGIONAL BY ROW table\nHINT: You must change the table locality before dropping this column
 ALTER TABLE regional_by_row_table_as DROP COLUMN crdb_region_col
 
 # Tests for altering the survivability of a REGIONAL BY ROW table.