restore: fast fail unsupported online restore with range keys

Fixes #150385

Release note: none

Author: msbutler

pkg/backup/restore_job.go

@@ -175,6 +175,13 @@ func rewriteBackupSpanKey(
 	return newKey, nil
 }
 
+var permanentRestoreError = errors.New("permanent restore error")
+
+func shouldFastFailRestore(err error) bool {
+	return errors.Is(err, permanentRestoreError) ||
+		pebble.IsCorruptionError(err) && errors.Is(err, backupFileReadError)
+}
+
 // restoreWithRetry attempts to run restore with retry logic and logs retries
 // accordingly.
 func restoreWithRetry(
@@ -217,9 +224,10 @@ func restoreWithRetry(
 			return roachpb.RowCount{}, jobs.MarkPauseRequestError(errors.UnwrapAll(err))
 		}
 
-		if pebble.IsCorruptionError(err) && errors.Is(err, backupFileReadError) {
+		if shouldFastFailRestore(err) {
 			return roachpb.RowCount{}, jobs.MarkAsPermanentJobError(err)
 		}
+
 		// If we are draining, it is unlikely we can start a
 		// new DistSQL flow. Exit with a retryable error so
 		// that another node can pick up the job.

pkg/backup/restore_online.go

@@ -310,7 +310,7 @@ func sendAddRemoteSSTWorker(
 				}
 				currentLayer = file.Layer
 				if file.HasRangeKeys {
-					return errors.Newf("online restore of range keys not supported")
+					return errors.Wrapf(permanentRestoreError, "online restore of range keys not supported")
 				}
 				if err := assertCommonPrefix(file.BackupFileEntrySpan, entry.ElidedPrefix); err != nil {
 					return err