Skip to content

Commit c8b6470

Browse files
wenyihu6tbg
authored andcommitted
asim: change defaultRebalancingSnapshotRate to 32MiB/s
This commit updates defaultRebalancingSnapshotRate from 16MiB/s to 32MiB/s to match with the default value of the kv.snapshot_rebalance.max_rate cluster setting. Epic: none Release note: none
1 parent b5fc7f2 commit c8b6470

File tree

3 files changed

+45
-45
lines changed

3 files changed

+45
-45
lines changed

pkg/kv/kvserver/asim/config/settings.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const (
1111
defaultTickInteval = 500 * time.Millisecond
1212
defaultMetricsInterval = 10 * time.Second
1313
defaultReplicaChangeBaseDelay = 100 * time.Millisecond
14-
defaultRebalancingSnapshotRate = 16 << 20 // 16MiB/s
14+
defaultRebalancingSnapshotRate = 32 << 20 // 32MiB/s
1515
defaultSplitQueueDelay = 100 * time.Millisecond
1616
defaultRangeSizeSplitThreshold = 512 * 1024 * 1024 // 512mb
1717
defaultRangeRebalanceThreshold = 0.05
@@ -57,8 +57,8 @@ type SimulationSettings struct {
5757
// movement.
5858
ReplicaChangeBaseDelay time.Duration
5959
// RebalancingSnapshotRate is rate at which newly added replicas will be
60-
// added based on the range size. e.g., When the range size is 16MB, and the
61-
// RebalancingSnapshotRate is 16 << 20, the delay for adding a replica wil be
60+
// added based on the range size. e.g., When the range size is 32MiB, and the
61+
// RebalancingSnapshotRate is 32 << 20, the delay for adding a replica wil be
6262
// 1 second + ReplicaChangeBaseDelay.
6363
RebalancingSnapshotRate int64
6464
// SplitQueueDelay is the delay that range splits take to complete.

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_add_node

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,16 @@ plot stat=replicas sample=1
3737
----
3838
301 ┼──────────────────────────────────────╭────────────────────────────────────────
3939
281 ┤ ╭──╯
40-
261 ┤ ─╯╯
41-
241 ┤ ╭──╯
42-
221 ┤ ╭╭─╯
43-
201 ┤ ╭──╯
44-
181 ┤ ╭──╯
45-
161 ┤ ─╯╯
46-
140 ┤ ╭╭─
47-
120 ┤ ╭──╯
48-
100 ┤ ╭──╯
49-
80 ┤ ╭─
40+
261 ┤ ╭──╯╯
41+
241 ┤ ╭──
42+
221 ┤ ╭──╯─
43+
201 ┤ ╭─╯─╯
44+
181 ┤ ╭──╯
45+
161 ┤ ╭──╯╯
46+
140 ┤ ╭─╯
47+
120 ┤ ╭──╯
48+
100 ┤ ╭──╯
49+
80 ┤ ╭─
5050
60 ┤ ╭╭─╯
5151
40 ┤ ╭──╯
5252
20 ┤ ╭──╯

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_fulldisk

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -19,46 +19,46 @@ OK
1919
# store 5. This is shown below as it sheds replicas.
2020
plot stat=replicas
2121
----
22-
345╭╮ ╭╮
23-
334╭─╮ ╭╮ ╭╮╭─╮╭╮╭╮╭╮╭─╭╮╯│ ╭─╭╮╭╮ ╭╮╯│╭─╭─╮╮─╭
24-
324╭╮╭─╮ ╭╭─│─│╭╯╭─╮╭─╭──╮╭╮╭─╮│╯╭╯╰╮╰╮╭╯│╮╰╮╭─╮╭╯╭╯╰╮─╮╭╯╰╮─╯╭│╯╰╮╮╭
25-
313╭╮╯╭╭─╮╭───╯ ╰╮╰│╮│╯╭│╮╯╰──╯╯╰╮╭╯╭╯│╯╭╯╭╰╮╮╭╯ │╯││││││╭╯╮╰│ ╭╭╯│╭│╭╯
26-
303 ┤╭──────────╯╰╮╭╯│╰╯╭╯│╰─╯│╭╯│╰╮╭╯╰─╯│ ╰╯╰╯╭╯ │╭╯─╯││╭╯╮╭│╰╭╯─╰╰─╯ ╰╯│─╭╯╯╰╯╰╯
27-
292 ┼─╮────────────╯ ╰╯╰╯╰│╭╯ ││ ╰─╰╯╰──╯╰╮╭╯ ││ ╰╯ ╰╰╯ ╰╯╰─╯╯ │╭╯ ╰─
28-
282╰─────────╮ ╰╯ ╰╯ ╰╯ ╰╯ ╰╯
29-
271 ┤ │╭─╮
30-
261╰╯ │ ╭╮ ╭╮
31-
250╰╮╭╯╰╮ ╭╮ ╭╮ ╭╮ ╭─╮ ╭╮ ╭╮ ╭─╮ ╭╯│ ╭
32-
240││ │╭╯╰╮╭╯│ ╭╯╰╮│ ╰╮ │╰╮ ╭╮ ╭╮ ╭╯╰╮ │ ╭╯ ╰││
33-
229╰╯ ╰╯ ││ ╰╮│ ╰╯ │╭╯ │ ││ │╰│ ╰╮╭╯ ╰╮ │ │ ╭╯╰
34-
219╰╯ ╰╯ ╰╯ ╰╮╭╯╰╮ ╭╯ │ ╭╯ ││ │╭╯ ╰╮│ ╰╮ ╭╮
35-
208 ││ │ │ ╰╮│ ╰╯ ╰╯ ╰╯ │ ╭╯
36-
198 ╰╯ ╰─╯ ╰ ╰╮ │ ╰
37-
187 ╰─
22+
340 ╭╮ ╭╮╭
23+
329 ╭╭─╭──╮╭─╮╭─╮╭─╭╮╭╭╮ ╭╮ ╭╮╮╭╭─╮─╭╭╮─╭╭╮╯╭╯
24+
319 ╭╮ ╭╮ ╭╮╭╭╮╭╮ ╭╮╭────╯─╯╰╯╭╰──────╮╭╯│─╭╯│╭╯╰╮╭╯╰│─╭╯│─╭╯╰─╯─
25+
308 ╭╭──╮╭╭────╯╰╮╭─╯╰╯╰╯ ╰╯ ╰╯ ╰─╰─╯╰╰╯╯╰─╯╰╰╯ ╰╯─╯╰─╯╰╰─╯╰╯ ╰
26+
297 ┼╮────────────────╯╭╯╰╭╮─╯╯╯╰╯╰╯││
27+
286 ┤╰───────────────╮╰╯ ││
28+
276 │╭─╮╭╯╰╮
29+
265 ╰╯ ╰╯ │╭─╮ ╭╮ ╭
30+
254 ╰╯ │ ││ ││
31+
243 ╰─╯╰─╯╰
32+
233 ╭╮
33+
222 ╰── ╭╮ │╰╮╭╯│ ╭
34+
211 │ ╭─╮ ╭╮│╰╮╭╯ ││ ╰─╯│ ╭╮
35+
200╰╮│ │ ╭╮ │╰╯ ╰╯ ╰╯ ╰╮ │╰╮ ╭─╮╭──╮╭─╮
36+
190 ┤ ╰╯ ╰╮╭╯╰─╰─╯ │ │ ││ ││ ╰─╯
37+
179╰╯ ╰─╯ ╰╯ ╰
3838
replicas
3939
initial store values: [s1=300, s2=300, s3=300, s4=300, s5=300] (stddev=0.00, mean=300.00, sum=1500)
40-
last store values: [s1=321, s2=337, s3=323, s4=324, s5=201] (stddev=50.42, mean=301.20, sum=1506)
40+
last store values: [s1=313, s2=334, s3=317, s4=340, s5=211] (stddev=47.10, mean=303.00, sum=1515)
4141

4242
# Plot the % of disk storage capacity used. We should see s5 hovering right
4343
# around 92.5-95% (the storage capacity threshold value).
4444
plot stat=disk_fraction_used
4545
----
46-
1.14 ╭─
47-
1.06 ╭╮ ╭╮ ╭─╮ │ │ ╭╮
48-
0.99╭─╮╭─╮ ╭╮ ╭─╮ ╭─╮ ╭─╮ ╭─╮ │╰╮ ╭──╮ ╭─╮ ╭╯╰╮ ╭─╮ │ ╰╮ ╭╯ ╰╮ ╭╯╰
49-
0.91 ╭─────╯ ╰╯ ╰╮╭╯╰─╯ ╰─╯ ╰╮│ ╰─╯ ╰╮╭╯ ╰╮│╮╭╯ │ ╭╯ ╰╮╭╯ ╰╮ ╭╯ ╰╮│ ╰──
50-
0.84 ┼─╮╭╯ ╰╯ ╰╯ ╰╯ ╰╯ ╰╯ ╰─╯ ╰╯ ╰─╯ ╰
51-
0.76 ┤ ╰╯
52-
0.68
53-
0.61
54-
0.53
55-
0.46
56-
0.38
57-
0.30
58-
0.23
46+
1.09╭╮ ╭
47+
1.02╭─╮╭╮ ╭─╮ ╭╮ ╭─╮ ╭╮ ╭╮ ││ │╰╮ ╭╮ ╭─╮ ╭╮ ╭╮
48+
0.95 ╭────────╮ │ ││╰───╮╭╯ ╰─╯╰╮│ ╰╮╭─╮ ╭╮│╰╮╭╯╰╮╭╯│╭╯ │ │╰╮ │ │╭╯╰╮╭╯╰╮╭
49+
0.87 ┤ ╭────────╯ ╰─╯ ╰╯ ╰╯ ╰╯ ╰╯ ╰─╯╯ ╰╯ ╰╯ ╰╯ ╰─╯ ╰╯ ╰╯ ╰
50+
0.80 ┼─╯
51+
0.73 ┤
52+
0.66
53+
0.58
54+
0.51
55+
0.44
56+
0.36
57+
0.29
58+
0.22
5959
0.15 ┤
60-
0.08
60+
0.07
6161
0.00 ┼───────────────────────────────────────────────────────────────────────────────
6262
disk_fraction_used
6363
initial store values: [s1=0.00, s2=0.00, s3=0.00, s4=0.00, s5=0.83] (stddev=0.33, mean=0.17, sum=1)
64-
last store values: [s1=0.00, s2=0.00, s3=0.00, s4=0.00, s5=1.02] (stddev=0.41, mean=0.20, sum=1)
64+
last store values: [s1=0.00, s2=0.00, s3=0.00, s4=0.00, s5=0.97] (stddev=0.39, mean=0.19, sum=1)

0 commit comments

Comments
 (0)