Skip to content

Commit cae45b3

Browse files
committed
logictest: restore tests that were commented a long time ago
Release note: None
1 parent 9948f59 commit cae45b3

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

pkg/sql/logictest/testdata/logic_test/rename_column

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,8 @@ ALTER TABLE users RENAME COLUMN id TO uid
9292
statement error cannot rename column "username" because view "v1" depends on it
9393
ALTER TABLE users RENAME COLUMN username TO name
9494

95-
# TODO(knz): restore test after #17269 / #10083 is fixed.
96-
#statement ok
97-
#ALTER TABLE users RENAME COLUMN species TO title
95+
statement ok
96+
ALTER TABLE users RENAME COLUMN species TO title
9897

9998
statement ok
10099
CREATE VIEW v2 AS SELECT id from users
@@ -105,9 +104,8 @@ DROP VIEW v1
105104
statement error cannot rename column "id" because view "v2" depends on it
106105
ALTER TABLE users RENAME COLUMN id TO uid
107106

108-
# TODO(knz): restore test after #17269 / #10083 is fixed.
109-
# statement ok
110-
# ALTER TABLE users RENAME COLUMN username TO name
107+
statement ok
108+
ALTER TABLE users RENAME COLUMN username TO name
111109

112110
statement ok
113111
DROP VIEW v2
@@ -116,14 +114,14 @@ query T
116114
SELECT column_name FROM [SHOW COLUMNS FROM users] ORDER BY column_name
117115
----
118116
id
119-
species
120-
username
117+
name
118+
title
121119

122120
statement ok
123121
SET vectorize=on
124122

125123
query T
126-
EXPLAIN ALTER TABLE users RENAME COLUMN species TO woo
124+
EXPLAIN ALTER TABLE users RENAME COLUMN title TO woo
127125
----
128126
distribution: local
129127
vectorized: true
@@ -138,24 +136,24 @@ query T
138136
SELECT column_name FROM [SHOW COLUMNS FROM users] ORDER BY column_name
139137
----
140138
id
141-
species
142-
username
139+
name
140+
title
143141

144142
skipif config schema-locked-disabled
145143
statement ok
146144
ALTER TABLE users SET (schema_locked=false);
147145

148146
# Check that a column can be added and renamed in the same statement
149147
statement ok
150-
ALTER TABLE users RENAME COLUMN species TO species_old,
151-
ADD COLUMN species STRING AS (species_old || ' woo') STORED
148+
ALTER TABLE users RENAME COLUMN title TO title_old,
149+
ADD COLUMN title STRING AS (title_old || ' woo') STORED
152150

153151
skipif config schema-locked-disabled
154152
statement ok
155153
ALTER TABLE users SET (schema_locked=true);
156154

157155
query T rowsort
158-
SELECT species FROM users
156+
SELECT title FROM users
159157
----
160158
cat woo
161159
rat woo

0 commit comments

Comments
 (0)