Merge #152031 #152034

152031: multiregionccl: update comments in test after a bug was fixed r=rafiss a=rafiss

The test had comments that described the buggy behavior. bb61a22 fixed the bug, so the comment needed updating.

Epic: None
Release note: None

152034: workload/schemachange: fix error code for unknown type r=rafiss a=rafiss

There is another error that can occur when creating a table with an unknown type, so this commit teaches the workload to handle it.

informs #150547
Release note: None

Co-authored-by: Rafi Shamim <[email protected]>

Author: craig[bot]

pkg/ccl/multiregionccl/multiregion_system_table_test.go

@@ -632,12 +632,11 @@ func TestDropRegionFromUserDatabaseCleansUpSystemTables(t *testing.T) {
 	// Drop a region from the USER database (not system database)
 	sDB.Exec(t, `ALTER DATABASE userdb DROP REGION "us-east2"`)
 
-	// BUG: sql_instances table is now empty, but it shouldn't be
-	// The region still exists in the system database, so instances should remain
+	// Verify that dropping a region from a user database doesn't affect system.sql_instances.
+	// The region still exists in the system database, so instances should remain unchanged.
 	finalCount := sDB.QueryStr(t, `SELECT count(*) FROM system.sql_instances`)
 	require.NotEmpty(t, finalCount)
-	// This assertion will fail, demonstrating the bug.
-	// The count should remain the same since we only dropped from userdb, not system
+	// The count should remain the same since we only dropped from userdb, not system.
 	require.Equal(t, initialCount[0][0], finalCount[0][0],
 		"sql_instances count should not change when dropping region from user database")
 }

pkg/workload/schemachange/operation_generator.go

@@ -1319,10 +1319,13 @@ func (og *operationGenerator) createTable(ctx context.Context, tx pgx.Tx) (*opSt
 	opStmt.potentialExecErrors.addAll(codesWithConditions{
 		{code: pgcode.Syntax, condition: hasVectorType},
 		{code: pgcode.FeatureNotSupported, condition: hasVectorType},
+		{code: pgcode.UndefinedObject, condition: hasVectorType},
 		{code: pgcode.Syntax, condition: hasCitextType},
 		{code: pgcode.FeatureNotSupported, condition: hasCitextType},
+		{code: pgcode.UndefinedObject, condition: hasCitextType},
 		{code: pgcode.Syntax, condition: hasLtreeType},
 		{code: pgcode.FeatureNotSupported, condition: hasLtreeType},
+		{code: pgcode.UndefinedObject, condition: hasLtreeType},
 	})
 	opStmt.sql = tree.Serialize(stmt)
 	return opStmt, nil