release-25.4: changefeedccl: remove fixed latency checks from pts benchmark test #154538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the fixed threshold checks for the `changefeed_stage_pts_manage_latency` and `changefeed_stage_pts_manage_error_latency` metrics in the cdc/multi-table-pts-benchmark roachtests. These thresholds were too rigid and caused noisy failures. Issue cockroachdb#154447 has been filed to track the goal of monitoring these metrics via roachperf instead. Fixes: cockroachdb#152900 Fixes: cockroachdb#152903 Fixes: cockroachdb#153017 Fixes: cockroachdb#154120 Fixes: cockroachdb#154122 Fixes: cockroachdb#154132 Fixes: cockroachdb#154302 Fixes: cockroachdb#154357 Epic: CRDB-1421 Release note: None
aerfrei
force-pushed
the
blathers/backport-release-25.4-154409
branch
from
1b85a82 to
db8ae3d
Compare
blathers-crl
bot
added
blathers-backport
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
|
This change is |
asg0451
approved these changes
Oct 1, 2025
blathers-crl
bot
added
backport-failed
backport-test-only
celeste-cockroachdb
bot
added
v25.4.0-prerelease
and removed
target-release-25.4.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #154409 on behalf of @aerfrei.
Removes the fixed threshold checks for the
changefeed_stage_pts_manage_latencyandchangefeed_stage_pts_manage_error_latencymetrics in thecdc/multi-table-pts-benchmark roachtests. These thresholds were
too rigid and caused noisy failures.
Issue #154447 has been filed to track the goal of monitoring these metrics
via roachperf instead.
Fixes: #152900
Fixes: #152903
Fixes: #153017
Fixes: #154120
Fixes: #154122
Fixes: #154132
Fixes: #154302
Fixes: #154357
Epic: CRDB-1421
Release note: None
Release justification: This is test only and will reduce noise