Skip to content

exempt hot path from iterator tracking (test run) #154791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

exempt hot path from iterator tracking (test run) #154791

wants to merge 5 commits into from
+65 −27

Conversation

RaduBerinde
Copy link
Member

go.mod: bump Pebble to 4cf08505504a

Changes:

  • 4cf08505 exempt WIP
  • 45d293d8 db: make iterator tracking configurable
  • 0d8ff1c3 db: track and report long-standing iterators
  • 0d82adc5 inflight: add data structure to detect long-running operations
  • 14834f0a github: run tests against custom cockroach Go
  • 0ac45a74 metrics: fix TestMetrics flake
  • 98c989b1 metamorphic: fix bug in suffix generation when prefix == startPrefix
  • d37d2f4b pebble: materialize virtual tables only if backing contains >= 30% garbage

Release note: none.
Epic: none.

exempt hot path from iterator tracking

@RaduBerinde
go.mod: bump Pebble to 4cf08505504a
6e6bca1 
Changes:

 * [`4cf08505`](cockroachdb/pebble@4cf08505) exempt WIP
 * [`45d293d8`](cockroachdb/pebble@45d293d8) db: make iterator tracking configurable
 * [`0d8ff1c3`](cockroachdb/pebble@0d8ff1c3) db: track and report long-standing iterators
 * [`0d82adc5`](cockroachdb/pebble@0d82adc5) inflight: add data structure to detect long-running operations
 * [`14834f0a`](cockroachdb/pebble@14834f0a) github: run tests against custom cockroach Go
 * [`0ac45a74`](cockroachdb/pebble@0ac45a74) metrics: fix TestMetrics flake
 * [`98c989b1`](cockroachdb/pebble@98c989b1) metamorphic: fix bug in suffix generation when prefix == startPrefix
 * [`d37d2f4b`](cockroachdb/pebble@d37d2f4b) pebble: materialize virtual tables only if backing contains >= 30% garbage

Release note: none.
Epic: none.
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Oct 3, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

⚪ Sysbench [SQL, 3node, oltp_read_write]
Metric Old Commit New Commit Delta Note
⚪ sec/op 9.741m ±1% 9.834m ±1% ~ p=0.116 n=15
⚪ allocs/op 7.773k ±1% 7.805k ±1% ~ p=0.146 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/cf800bd/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/cf800bd8b0f5c156b5cd3989055a21198965b6d5/bin/pkg_sql_tests benchdiff/cf800bd/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/cf800bd/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=61a9d7d --new=cf800bd ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_read_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 2.133m ±2% 2.204m ±1% +3.32% p=0.000 n=15
🔴 allocs/op 1.901k ±0% 1.916k ±0% +0.79% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/cf800bd/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/cf800bd8b0f5c156b5cd3989055a21198965b6d5/bin/pkg_sql_tests benchdiff/cf800bd/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/cf800bd/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=61a9d7d --new=cf800bd ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_write_only]
Metric Old Commit New Commit Delta Note
⚪ sec/op 3.102m ±5% 3.221m ±4% ~ p=0.041 n=15
🔴 allocs/op 3.886k ±0% 3.954k ±0% +1.75% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/cf800bd/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/cf800bd8b0f5c156b5cd3989055a21198965b6d5/bin/pkg_sql_tests benchdiff/cf800bd/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/cf800bd/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=61a9d7d --new=cf800bd ./pkg/sql/tests
Artifacts

download:

mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/cf800bd8b0f5c156b5cd3989055a21198965b6d5/18232779897-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/61a9d7d77b22abaa9b4965b78d0d512f72237ace/18232779897-1/\* old/

built with commit: cf800bd8b0f5c156b5cd3989055a21198965b6d5

@cockroach-teamcity cockroach-teamcity added the X-perf-check Microbenchmarks CI: Added to a PR if a performance regression is detected and should be checked label Oct 3, 2025
@RaduBerinde RaduBerinde force-pushed the radu/pebble-master-4cf08505504a branch from cf800bd to 2095b18 Compare October 3, 2025 22:52
@cockroach-teamcity
Copy link
Member

⚪ Sysbench [SQL, 3node, oltp_read_write]
Metric Old Commit New Commit Delta Note
⚪ sec/op 10.79m ±4% 10.96m ±3% ~ p=0.367 n=15
⚪ allocs/op 7.861k ±1% 7.858k ±2% ~ p=0.170 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/2095b18/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2095b1898285a9679d04ea401093a6cfee26a09f/bin/pkg_sql_tests benchdiff/2095b18/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2095b18/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=61a9d7d --new=2095b18 ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_read_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 2.113m ±0% 2.183m ±0% +3.32% p=0.000 n=15
🔴 allocs/op 1.901k ±0% 1.916k ±0% +0.79% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/2095b18/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2095b1898285a9679d04ea401093a6cfee26a09f/bin/pkg_sql_tests benchdiff/2095b18/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2095b18/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=61a9d7d --new=2095b18 ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_write_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 3.020m ±1% 3.118m ±1% +3.24% p=0.000 n=15
🔴 allocs/op 3.876k ±0% 3.948k ±0% +1.86% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/2095b18/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2095b1898285a9679d04ea401093a6cfee26a09f/bin/pkg_sql_tests benchdiff/2095b18/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2095b18/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=61a9d7d --new=2095b18 ./pkg/sql/tests
Artifacts

download:

mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/2095b1898285a9679d04ea401093a6cfee26a09f/18235613262-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/61a9d7d77b22abaa9b4965b78d0d512f72237ace/18235613262-1/\* old/

built with commit: 2095b1898285a9679d04ea401093a6cfee26a09f

@RaduBerinde RaduBerinde force-pushed the radu/pebble-master-4cf08505504a branch from 2095b18 to ab99b67 Compare October 5, 2025 15:51
@cockroach-teamcity
Copy link
Member

⚪ Sysbench [SQL, 3node, oltp_read_write]
Metric Old Commit New Commit Delta Note
⚪ sec/op 10.51m ±7% 10.56m ±2% ~ p=0.305 n=15
⚪ allocs/op 7.780k ±1% 7.785k ±1% ~ p=0.588 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/ab99b67/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/ab99b6781e5422ab44a206258ea57aadfb8bfd8e/bin/pkg_sql_tests benchdiff/ab99b67/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/ab99b67/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=61a9d7d --new=ab99b67 ./pkg/sql/tests
⚪ Sysbench [KV, 3node, oltp_read_only]
Metric Old Commit New Commit Delta Note
⚪ sec/op 2.099m ±1% 2.099m ±1% ~ p=0.967 n=15
⚪ allocs/op 1.901k ±0% 1.901k ±0% ~ p=0.640 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/ab99b67/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/ab99b6781e5422ab44a206258ea57aadfb8bfd8e/bin/pkg_sql_tests benchdiff/ab99b67/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/ab99b67/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=61a9d7d --new=ab99b67 ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_write_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 2.999m ±0% 3.085m ±0% +2.88% p=0.000 n=15
🔴 allocs/op 3.871k ±0% 3.931k ±0% +1.55% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/ab99b67/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/ab99b6781e5422ab44a206258ea57aadfb8bfd8e/bin/pkg_sql_tests benchdiff/ab99b67/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/ab99b67/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=61a9d7d --new=ab99b67 ./pkg/sql/tests
Artifacts

download:

mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/ab99b6781e5422ab44a206258ea57aadfb8bfd8e/18260975628-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/61a9d7d77b22abaa9b4965b78d0d512f72237ace/18260975628-1/\* old/

built with commit: ab99b6781e5422ab44a206258ea57aadfb8bfd8e

@cockroach-teamcity
Copy link
Member

⚪ Sysbench [SQL, 3node, oltp_read_write]
Metric Old Commit New Commit Delta Note
⚪ sec/op 9.430m ±0% 9.440m ±1% ~ p=0.624 n=15
⚪ allocs/op 7.731k ±1% 7.743k ±1% ~ p=0.139 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/25fcf08/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/25fcf088f43b3ad9936de5a96b62b18b303781ad/bin/pkg_sql_tests benchdiff/25fcf08/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/25fcf08/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=61a9d7d --new=25fcf08 ./pkg/sql/tests
⚪ Sysbench [KV, 3node, oltp_read_only]
Metric Old Commit New Commit Delta Note
⚪ sec/op 2.114m ±1% 2.102m ±1% ~ p=0.106 n=15
⚪ allocs/op 1.901k ±0% 1.901k ±0% 0.00% p=0.022 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/25fcf08/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/25fcf088f43b3ad9936de5a96b62b18b303781ad/bin/pkg_sql_tests benchdiff/25fcf08/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/25fcf08/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=61a9d7d --new=25fcf08 ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_write_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 3.015m ±1% 3.051m ±1% +1.20% p=0.001 n=15
🔴 allocs/op 3.874k ±0% 3.903k ±0% +0.75% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/25fcf08/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/25fcf088f43b3ad9936de5a96b62b18b303781ad/bin/pkg_sql_tests benchdiff/25fcf08/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/25fcf08/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=61a9d7d --new=25fcf08 ./pkg/sql/tests
Artifacts

download:

mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/25fcf088f43b3ad9936de5a96b62b18b303781ad/18267500571-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/61a9d7d77b22abaa9b4965b78d0d512f72237ace/18267500571-1/\* old/

built with commit: 25fcf088f43b3ad9936de5a96b62b18b303781ad

@RaduBerinde RaduBerinde force-pushed the radu/pebble-master-4cf08505504a branch 2 times, most recently from 24a0612 to 83451d9 Compare October 6, 2025 16:46
@RaduBerinde RaduBerinde force-pushed the radu/pebble-master-4cf08505504a branch from 83451d9 to c76846d Compare October 6, 2025 17:24
@cockroach-teamcity
Copy link
Member

⚪ Sysbench [SQL, 3node, oltp_read_write]
Metric Old Commit New Commit Delta Note
⚪ sec/op 10.78m ±1% 10.79m ±1% ~ p=0.806 n=15
⚪ allocs/op 7.773k ±2% 7.850k ±2% ~ p=0.493 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/c76846d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c76846d4518d19f6683ad8f4325df962f6faa301/bin/pkg_sql_tests benchdiff/c76846d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c76846d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=61a9d7d --new=c76846d ./pkg/sql/tests
⚪ Sysbench [KV, 3node, oltp_read_only]
Metric Old Commit New Commit Delta Note
⚪ sec/op 2.191m ±1% 2.195m ±2% ~ p=0.806 n=15
⚪ allocs/op 1.902k ±0% 1.901k ±0% ~ p=0.282 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/c76846d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c76846d4518d19f6683ad8f4325df962f6faa301/bin/pkg_sql_tests benchdiff/c76846d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c76846d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=61a9d7d --new=c76846d ./pkg/sql/tests
⚪ Sysbench [KV, 3node, oltp_write_only]
Metric Old Commit New Commit Delta Note
⚪ sec/op 3.065m ±1% 3.075m ±1% ~ p=0.345 n=15
⚪ allocs/op 3.880k ±0% 3.881k ±0% ~ p=0.862 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/c76846d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c76846d4518d19f6683ad8f4325df962f6faa301/bin/pkg_sql_tests benchdiff/c76846d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c76846d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61a9d7d/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61a9d7d77b22abaa9b4965b78d0d512f72237ace/bin/pkg_sql_tests benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61a9d7d/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=61a9d7d --new=c76846d ./pkg/sql/tests
Artifacts

download:

mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/c76846d4518d19f6683ad8f4325df962f6faa301/18289068167-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/61a9d7d77b22abaa9b4965b78d0d512f72237ace/18289068167-1/\* old/

built with commit: c76846d4518d19f6683ad8f4325df962f6faa301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
X-perf-check Microbenchmarks CI: Added to a PR if a performance regression is detected and should be checked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaduBerinde @cockroach-teamcity