build: fix behavior of FIPS build #156976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
rickystewart
force-pushed
the
ricky/yknymotmrtvp
branch
from
67f8763 to
a3bf03b
Compare
Prior to this change, the FIPS build did not have FIPS mode enabled by default. This PR addresses this via a change to `rules_go`. We still need to fix `rules_go` so that `GOFIPS140=v1.0.0` will work, but that requires more tweaking (see [discussion](bazel-contrib/rules_go#4449 (comment))). Release note: none Epic: DEVINF-1477
rickystewart
force-pushed
the
ricky/yknymotmrtvp
branch
from
a3bf03b to
b26c676
Compare
rail
approved these changes
Nov 6, 2025
Collaborator
Author
|
bors r=rail |
Contributor
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Nov 7, 2025
This removes an unnecessary debugging switch that was accidentally flipped in cockroachdb#156976, making builds unnecessarily verbose. Release note: none Epic: none
craig bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
157067: allocator: change rebalanceStores receiver to *clusterState r=wenyihu6 a=tbg Change rebalanceStores from *allocatorState to *clusterState receiver and add rng and dsm as parameters. This enables direct testing of rebalanceStores from cluster_state_test.go without instantiating allocatorState. Also update ensureAnalyzedConstraints and computeCandidatesForRange to use *clusterState receiver. I intentionally didn't move methods around to avoid large diffs and merge conflicts. At some point, I'll do a "mostly moving things around" PR when we don't have as much inflight. The upshot of the refactor is that we can now use `TestClusterState` to exercise `rebalanceStores`. I added a TODO to also print the trace output. This is turning into a bigger yak shave than I anticipated (we need to pare down the default trace output to make sure it's deterministic and not noisy), so I'll send that separately. Once I have that, I'll start adding store health logic to the allocator while adding suitable tests. Informs #156776. Epic: CRDB-55052 157078: build: update rules_go r=rail a=rickystewart This removes an unnecessary debugging switch that was accidentally flipped in #156976, making builds unnecessarily verbose. Release note: none Epic: none Co-authored-by: Tobias Grieger <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the FIPS build did not have FIPS mode enabled by default. This PR addresses this via a change to
rules_go. We still need to fixrules_goso thatGOFIPS140=v1.0.0will work, but that requires more tweaking (see discussion).Release note: none
Epic: DEVINF-1477