Skip to content

sql: add ALTER TABLE ... SET SCHEMA to the declerative schema changer #158141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+1,064 −740
Open

sql: add ALTER TABLE ... SET SCHEMA to the declerative schema changer #158141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a2a0ab
sql: change namespace attr to support `SET SCHEMA`
shghasemi Nov 19, 2025
cd6cc7a
sql: add `ALTER TABLE ... SET SCHEMA` to the declerative schema changer
shghasemi Nov 18, 2025
ac6898d
sql: fix review comments and test fails
shghasemi Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pkg/backup/testdata/backup-restore/plpgsql_procedures
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,10 @@ ALTER TABLE sc1.tbl1 RENAME TO tbl1_new
pq: cannot rename relation "db1_new.sc1.tbl1" because procedure "p1" depends on it
HINT: consider dropping "p1" first.

# TODO(mgartner): The error message should say "procedure".
exec-sql
ALTER TABLE sc1.tbl1 SET SCHEMA sc2;
----
pq: cannot set schema on relation "tbl1" because function "p1" depends on it
pq: cannot set schema on relation "db1_new.sc1.tbl1" because procedure "p1" depends on it
HINT: consider dropping "p1" first.

exec-sql
Expand Down Expand Up @@ -389,7 +388,7 @@ HINT: consider dropping "p1" first.
exec-sql
ALTER TABLE sc1.tbl1 SET SCHEMA sc2;
----
pq: cannot set schema on relation "tbl1" because function "p1" depends on it
pq: cannot set schema on relation "db1.sc1.tbl1" because procedure "p1" depends on it
HINT: consider dropping "p1" first.

exec-sql
Expand Down
4 changes: 2 additions & 2 deletions pkg/backup/testdata/backup-restore/plpgsql_user_defined_functions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ HINT: consider dropping "f1" first.
exec-sql
ALTER TABLE sc1.tbl1 SET SCHEMA sc2;
----
pq: cannot set schema on relation "tbl1" because function "f1" depends on it
pq: cannot set schema on relation "db1_new.sc1.tbl1" because function "f1" depends on it
HINT: consider dropping "f1" first.

exec-sql
Expand Down Expand Up @@ -469,7 +469,7 @@ HINT: consider dropping "f1" first.
exec-sql
ALTER TABLE sc1.tbl1 SET SCHEMA sc2;
----
pq: cannot set schema on relation "tbl1" because function "f1" depends on it
pq: cannot set schema on relation "db1.sc1.tbl1" because function "f1" depends on it
HINT: consider dropping "f1" first.

exec-sql
Expand Down
5 changes: 2 additions & 3 deletions pkg/backup/testdata/backup-restore/procedures
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,10 @@ ALTER TABLE sc1.tbl1 RENAME TO tbl1_new
pq: cannot rename relation "db1_new.sc1.tbl1" because procedure "p1" depends on it
HINT: consider dropping "p1" first.

# TODO(mgartner): The error message should say "procedure".
exec-sql
ALTER TABLE sc1.tbl1 SET SCHEMA sc2;
----
pq: cannot set schema on relation "tbl1" because function "p1" depends on it
pq: cannot set schema on relation "db1_new.sc1.tbl1" because procedure "p1" depends on it
HINT: consider dropping "p1" first.

exec-sql
Expand Down Expand Up @@ -361,7 +360,7 @@ HINT: consider dropping "p1" first.
exec-sql
ALTER TABLE sc1.tbl1 SET SCHEMA sc2;
----
pq: cannot set schema on relation "tbl1" because function "p1" depends on it
pq: cannot set schema on relation "db1.sc1.tbl1" because procedure "p1" depends on it
HINT: consider dropping "p1" first.

exec-sql
Expand Down
2 changes: 1 addition & 1 deletion pkg/backup/testdata/backup-restore/triggers
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ pq: cannot rename relation "db1_new.sc1.tbl1" because trigger "tr1" on table "tb
exec-sql
ALTER TABLE sc1.tbl1 SET SCHEMA sc2;
----
pq: cannot set schema on relation "tbl1" because trigger "tr1" on table "tbl1" depends on it
pq: cannot set schema on relation "db1_new.sc1.tbl1" because trigger "tr1" on table "tbl1" depends on it

exec-sql
DROP TYPE sc1.enum1
Expand Down
4 changes: 2 additions & 2 deletions pkg/backup/testdata/backup-restore/user-defined-functions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ HINT: consider dropping "f1" first.
exec-sql
ALTER TABLE sc1.tbl1 SET SCHEMA sc2;
----
pq: cannot set schema on relation "tbl1" because function "f1" depends on it
pq: cannot set schema on relation "db1_new.sc1.tbl1" because function "f1" depends on it
HINT: consider dropping "f1" first.

exec-sql
Expand Down Expand Up @@ -358,7 +358,7 @@ HINT: consider dropping "f1" first.
exec-sql
ALTER TABLE sc1.tbl1 SET SCHEMA sc2;
----
pq: cannot set schema on relation "tbl1" because function "f1" depends on it
pq: cannot set schema on relation "db1.sc1.tbl1" because function "f1" depends on it
HINT: consider dropping "f1" first.

exec-sql
Expand Down
28 changes: 28 additions & 0 deletions pkg/ccl/schemachangerccl/sctestbackupccl/backup_base_generated_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading