asim: specify node capacity in cores, not nanos/sec #158144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
angeladietz
force-pushed
the
node-capacity-units
branch
2 times, most recently
from
4a9612c to
8972085
Compare
Previously, the datadriven asim tests expressed node capacity in nanoseconds/core which are difficult to read due to lots of zeros. Now, the node capacity is expressed in cores (float) which is much more readable and less prone to user error. For example, `node_cpu_rate_capacity=8000000000` is now expressed as `node_cpu_cores=8`. Fixes cockroachdb#156845 Epic: CRDB-55052 Release note: none.
angeladietz
force-pushed
the
node-capacity-units
branch
from
8972085 to
b418f28
Compare
Contributor
Author
|
For now, i only updated the the node capacity in the input format, but not in the underlying data structures, like BasicCluster.NodeCPURateCapacity and ClusterInfo.NodeCPURateCapacityNanos. Should the CPU units be updated there too, or is it only the input format we're worried about? |
wenyihu6
approved these changes
Nov 21, 2025
Contributor
wenyihu6
left a comment
wenyihu6
left a comment
There was a problem hiding this comment.
I think only the input, so this should be enough.
Reviewable status:
complete! 1 of 0 LGTMs obtained
pkg/kv/kvserver/asim/state/node_cpu_cores_test.go line 14 at r1 (raw file):
) func TestNodeCPUCores_ToRateCapacityNanos(t *testing.T) {
Nice test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the datadriven asim tests expressed node capacity in nanoseconds/core which are difficult to read due to lots of zeros. Now, the node capacity is expressed in cores (float) which is much more readable and less prone to user error. For example,
node_cpu_rate_capacity=8000000000is now expressed asnode_cpu_cores=8.Fixes #156845
Epic: CRDB-55052
Release note: none.