ts: record child metrics with low frequency poller #158148
Open
+520
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
jasonlmfong
commented
Nov 20, 2025
Comment on lines
+236
to
+241
| if m.EnableLowFreqChildCollection == nil { | ||
| return true | ||
| } | ||
| return *m.EnableLowFreqChildCollection | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
chose to default this to true because I think it would be quite painful to manually turn this on for each metric
Comment on lines
+475
to
+493
| // Record child metrics from app registry for system tenant only. | ||
| now := mr.clock.Now() | ||
| recorder := registryRecorder{ | ||
| registry: mr.mu.appRegistry, | ||
| format: nodeTimeSeriesPrefix, | ||
| source: mr.mu.desc.NodeID.String(), | ||
| timestampNanos: now.UnixNano(), | ||
| } | ||
| recorder.recordChangefeedChildMetrics(&data) | ||
|
|
||
| // Record child metrics from app-level registries for secondary tenants | ||
| for tenantID, r := range mr.mu.tenantRegistries { | ||
| tenantRecorder := registryRecorder{ | ||
| registry: r, | ||
| format: nodeTimeSeriesPrefix, | ||
| source: tsutil.MakeTenantSource(mr.mu.desc.NodeID.String(), tenantID.String()), | ||
| timestampNanos: now.UnixNano(), | ||
| } | ||
| tenantRecorder.recordChangefeedChildMetrics(&data) | ||
| } |
Member
Author
There was a problem hiding this comment.
changefeed metrics only live on app registry (and tenant app registry)
| for i, label := range childMetric.Label { | ||
| sanitizedLabels[i].key = metric.ExportedLabel(label.GetName()) | ||
| sanitizedLabels[i].value = label.GetValue() | ||
| } |
Member
Author
There was a problem hiding this comment.
this is aligned with prometheus export:
keys are cleaned and values are preserved
| 12, | ||
| "/System/tsd//1m/1924-09-18T08:00:00Z/", | ||
| }, | ||
| { |
Member
Author
There was a problem hiding this comment.
prove that keys can have special characters
This change adds the ability to get changefeed child metrics to be recorded. The child metrics have their names augmented with their labels. Epic: CRDB-55079 Release: None
jasonlmfong
force-pushed
the
jf/ts-collect-lfhc-changefeed
branch
from
4748184 to
2c02b81
Compare
jasonlmfong
requested review from
Abhinav1299,
aa-joshi and
arjunmahishi
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to get changefeed child metrics to be recorded. The child metrics have their names augmented with their labels.
Epic: CRDB-55079
Release: None