Skip to content

sql: skip external process under deadlock in TestShowLastQueryStatistics #158169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Open

sql: skip external process under deadlock in TestShowLastQueryStatistics #158169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pkg/sql/conn_executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1408,8 +1408,15 @@ func TestShowLastQueryStatistics(t *testing.T) {
skip.UnderRace(t, "measure planning latency which is slower than usual under race")

ctx := context.Background()
params := base.TestServerArgs{}
s, sqlConn, _ := serverutils.StartServer(t, params)
var testTenant base.DefaultTestTenantOptions
if syncutil.DeadlockEnabled {
// Under deadlock, the planning latency in the external process mode can
// sometimes exceed 1s allowed limit.
testTenant = base.TestSkipForExternalProcessMode()
}
s, sqlConn, _ := serverutils.StartServer(t, base.TestServerArgs{
DefaultTestTenant: testTenant,
})
defer s.Stopper().Stop(ctx)

testCases := []struct {
Expand Down