changefeedccl: db-level feeds: fail the feed if the watched db is dropped/renamed #159198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Contributor
Author
log-head
force-pushed
the
log-head/db-level-changefeed-dropped-db
branch
from
e79b7a6 to
dc55dfb
Compare
If you specify a table in a database-level changefeed that's in another database, it will return a terminal error instead of an assertion-failed error. Epic: None Release note: None
Previously the tableset watcher would incorrectly report table drops for databases and schemas. This is now fixed. Epic: none Release note: None
Add a table watcher check to the change frontier before saving progress. If we encounter a new table, save progress up to that point and then die. Fixes: cockroachdb#148834 Release note: None
Use filters from changefeed details to filter tables in db-level feeds. Fixes: cockroachdb#156859 Release note: None
log-head
force-pushed
the
log-head/db-level-changefeed-dropped-db
branch
2 times, most recently
from
32c5a2b to
a4adfed
Compare
Contributor
Author
|
@andyyang890 and I discussed instead checking for the database drop in the schema feed. One issue with this is that polling and validating table descriptors is paused when schema locked is active. So while schema locked is active, this wouldn't be running to check if the database has been dropped. So, I'm going to keep checking in the tableset watcher for the database drop. Additionally, this works in the case of the changefeed hibernating while there's an empty tableset, since there will be a watcher running but not a schema feed. |
log-head
changed the title
…pped This patch fails a db-level changefeed when its watched database is dropped. Epic: CRDB-55919 Fixes: cockroachdb#156780 Release note (sql change): A database-level changefeed will now fail when its watched database is dropped.
log-head
force-pushed
the
log-head/db-level-changefeed-dropped-db
branch
from
a4adfed to
5bef842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fails a db-level changefeed when its watched database is dropped.
Epic: CRDB-55919
Fixes: #156780
Release note (sql change): A database-level changefeed will now fail when its watched database is dropped.