Skip to content

Conversation

@williamchoe3
Copy link
Contributor

@williamchoe3 williamchoe3 commented Dec 18, 2025

Backport 1/1 commits from #159751 on behalf of @williamchoe3.


Because of behavior described in #159708, certain failure modes can result in test.xml files that result in ambiguous github issues.

This change simply adds a message to the eventual github issue body so that test-eng or any team that's triaging can better see what's going on at a glance

Informs #159708


Release justification: CI testing related change

@williamchoe3 williamchoe3 requested a review from a team as a code owner December 18, 2025 17:17
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 18, 2025
@blathers-crl blathers-crl bot requested a review from rickystewart December 18, 2025 17:17
@blathers-crl
Copy link

blathers-crl bot commented Dec 18, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-testeng TestEng Team labels Dec 18, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Dec 18, 2025

✅ PR #159826 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: This PR adds enhancements to the GitHub issue generation from test failure reports to include more descriptive messages. The changes are specific to a testing infrastructure tool used internally (indicated by 'pkg/cmd/' directory under non-production file patterns) and thus, fall under the exception for non-production and test-only changes. The files modified ('pkg/cmd/bazci/githubpost/githubpost.go', 'pkg/cmd/bazci/githubpost/githubpost_test.go', and 'pkg/cmd/bazci/githubpost/testdata/test-error-142.xml') support testing infrastructure and tools, exempting them from the standard backport policy requirements. Moreover, the PR contains a release justification indicating it's intended for CI testing related changes, confirming its alignment with the exceptions provided by the policy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@williamchoe3 williamchoe3 force-pushed the blathers/backport-release-25.2-159751 branch from cbc6c53 to d1ec51d Compare December 18, 2025 20:08
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Reminder: it has been 2 weeks please merge or close your backport!

…lified

unit test names

Epic: None
Release note: None
@williamchoe3 williamchoe3 force-pushed the blathers/backport-release-25.2-159751 branch from d1ec51d to c465113 Compare January 5, 2026 17:11
@williamchoe3
Copy link
Contributor Author

Rebasing / Rerunning CI since it's been a few weeks

@williamchoe3 williamchoe3 merged commit 0ffdd84 into cockroachdb:release-25.2 Jan 5, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot. T-testeng TestEng Team target-release-25.2.11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants