kvserver: remove TestProcessSplitAfterRightHandSideHasBeenRemoved #159882
+1
−561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
tbg
force-pushed
the
deflake-TestProcessSplitAfterRightHandSideHasBeenRemoved
branch
from
6a5bfdc to
7270a51
Compare
tbg
force-pushed
the
deflake-TestProcessSplitAfterRightHandSideHasBeenRemoved
branch
from
7270a51 to
33b2af9
Compare
tbg
changed the title
The test had a race condition between lease transfer verification and partition activation. After transferring the lease from n1 to n3, there was a window where n1 could re-acquire the lease before the partition was activated, causing the subsequent increment to hang waiting for a slow proposal on the now-partitioned n1. I spent a couple of hours trying to deflake this, but whenever you fix one thing, another springs up. This test is not maintainable, and is highly complex. The [split_pre_apply] tests cover this functionality. Testing it from "far away" does give some extra coverage, but at a steep price for maintainability, which we are not ready to pay, so the test is removed in this commit. [split_pre_apply]: https://github.com/tbg/cockroach/blob/7270a51a0430999661ed15320527ccc04d796a14/pkg/kv/kvserver/testdata/replica_lifecycle/split_pre_apply.txt Fixes (on 26.1) cockroachdb#159676 Fixes cockroachdb#158295.
tbg
force-pushed
the
deflake-TestProcessSplitAfterRightHandSideHasBeenRemoved
branch
from
33b2af9 to
e8f5a3f
Compare
arulajmani
approved these changes
Jan 7, 2026
Collaborator
arulajmani
left a comment
arulajmani
left a comment
There was a problem hiding this comment.
bors r+
@arulajmani reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @tbg).
-- commits line 14 at r1:
This makes me smile!
Contributor
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #158295: branch-release-26.1. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test had a race condition between lease transfer verification and
partition activation. After transferring the lease from n1 to n3, there
was a window where n1 could re-acquire the lease before the partition
was activated, causing the subsequent increment to hang waiting for a
slow proposal on the now-partitioned n1.
I spent a couple of hours trying to deflake this, but whenever you fix
one thing, another springs up. This test is not maintainable, and is
highly complex.
The split_pre_apply tests cover this functionality. Testing it from "far
away" does give some extra coverage, but at a steep price for maintainability,
which we are not ready to pay, so the test is removed in this commit.
Fixes (on 26.1) #159676
Fixes #158295.