Skip to content

Conversation

@aerfrei
Copy link
Contributor

@aerfrei aerfrei commented Dec 26, 2025

Backport 1/1 commits from #160093.

/cc @cockroachdb/release

Release Justification: test only


We were seeing failures on this randomized test when these columns were generated. The testutils parquet decoder can't handle this type (added in #132944) so these fail, but it doesn't represent a real issue.

This fix skips these the randomly generated test cases that include this column type.

Fixes: #154011
Epic: none
Release note: None

We were seeing failures on this randomized test when these
columns were generated. The testutils parquet decoder can't
handle this type (added in cockroachdb#132944) so these fail, but it
doesn't represent a real issue.

This fix skips these the randomly generated test cases that
include this column type.

Fixes: cockroachdb#154011
Epic: none

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Dec 26, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-cdc labels Dec 26, 2025
@aerfrei aerfrei marked this pull request as ready for review December 26, 2025 18:58
@aerfrei aerfrei requested a review from a team as a code owner December 26, 2025 18:58
@aerfrei aerfrei requested review from yuzefovich and removed request for a team December 26, 2025 18:58
@blathers-crl
Copy link

blathers-crl bot commented Dec 26, 2025

✅ PR #160201 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The pull request modifies a test file which is a non-production code according to the backport policy exemption for changes affecting only non-production code, tests, or development tools. The file (pkg/sql/importer/exportparquet_test.go) clearly falls under this category as it's a test file. The PR body also contains a 'Release Justification: test only', providing explicit justification that aligns with the policy guidelines for non-production code changes.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuzefovich reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @aerfrei).

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Dec 26, 2025
@aerfrei aerfrei merged commit bf44b88 into cockroachdb:release-24.3 Dec 26, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes T-cdc target-release-24.3.26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants