blobfixture: add PreventGC flag #160313
Closed
blobfixture: add PreventGC flag #160313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev-cao
requested review from
DarrylWong and
srosenberg
and removed request for
a team
Member
|
This change is |
kev-cao
requested review from
jeffswenson
and removed request for
DarrylWong and
srosenberg
kev-cao
force-pushed
the
blobfixture/prevent-gc
branch
from
5a064a3 to
246b0fc
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
github-actions
bot
added
the
o-AI-Review-Potential-Issue-Detected
This commit adds the `LastFailureAt` flag to the fixture framework. When set, a fixture will not be GC'd for a week, even if it has been made obsolete by a more recent fixture. Informs: cockroachdb#160073 Release note: None
kev-cao
force-pushed
the
blobfixture/prevent-gc
branch
from
246b0fc to
f966445
Compare
kev-cao
added
O-AI-Review-Not-Helpful
Contributor
Author
|
Merged in #160338 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
PreventGCflag to the fixture framework. When set, a fixture will not be GC'd for a week, even if it has been made obsolete by a more recent fixture.Informs: #160073
Release note: None