ccl/schemachanger: avoid table restore flavors in mixed version #160344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
rafiss
approved these changes
Jan 5, 2026
| }, func(t *testing.T, cs CumulativeTestCaseSpec) { | ||
| if backupArgs.isMultiRegion { | ||
| // Speed up the mixed version multiregion cases by excluding restores of individual | ||
| // tables in the mixed version state.. |
rafiss
added
backport-25.4.x
Previously, the schema changer CCL backup / restore tests could timeout due to complex depth of coverage offered. To address this, this patch will avoid testing per-table restore flavors for multiregion and mixed version variants, so that fewer permutations are tested. Fixes: cockroachdb#160314 Fixes: cockroachdb#160275 Release note: None
fqazi
force-pushed
the
speedUpMixedVersion
branch
from
0dbe5b5 to
70194cd
Compare
Collaborator
Author
|
@rafiss TFTR! bors r+ |
Contributor
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #160314: branch-release-26.1. Issue #160275: branch-release-25.4, branch-release-26.1. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This was referenced Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the schema changer CCL backup / restore tests could timeout due to complex depth of coverage offered. To address this, this patch will avoid testing per-table restore flavors for multiregion and mixed version variants, so that fewer permutations are tested.
Fixes: #160314
Fixes: #160275
Release note: None