Skip to content

Conversation

@yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Jan 2, 2026

Backport 1/1 commits from #160397 on behalf of @yuzefovich.


We've seen a timeout in this test twice under race with no clear signs of things going wrong, other than the cluster being overloaded - it uses 5node config, so let's just skip it under race.

Fixes: #160391.
Release note: None


Release justification: test-only change.

We've seen a timeout in this test twice under race with no clear signs
of things going wrong, other than the cluster being overloaded - it uses
5node config, so let's just skip it under race.

Release note: None
@yuzefovich yuzefovich force-pushed the blathers/backport-release-24.3-160397 branch from ed87b9c to ec63f2e Compare January 2, 2026 23:05
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 2, 2026
@blathers-crl blathers-crl bot requested a review from michae2 January 2, 2026 23:05
@blathers-crl
Copy link

blathers-crl bot commented Jan 2, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-queries SQL Queries Team labels Jan 2, 2026
@blathers-crl
Copy link

blathers-crl bot commented Jan 2, 2026

✅ PR #160411 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The pull request concerns changes to a file specifically listed under the test-only directories pattern (pkg/sql/logictest/testdata/), indicating that the changes affect non-production code. According to the CockroachDB Backport Policy, modifications to non-production, test-only files are exempt from the requirement to justify critical bugs or feature flag gating. The PR clearly denotes these changes as test-only modifications in the PR title and body, further emphasizing their compliance. The file in question, 'distsql_numtables', is part of the logic tests, which serve to verify correctness in a non-production environment rather than influence the production behavior of the database system.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Jan 2, 2026
@yuzefovich yuzefovich merged commit 60b41ce into cockroachdb:release-24.3 Jan 2, 2026
17 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-24.3-160397 branch January 2, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-queries SQL Queries Team target-release-24.3.26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants