Skip to content

Conversation

@yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Jan 5, 2026

Backport 1/1 commits from #160209 on behalf of @yuzefovich.


We already skip tpcc in bigInitialData, and I think it was a mistake that tpccmultidb wasn't marked in the same way. In particular, this will make it so that we don't run some of the test cases.

The reason I was looking into this is that TestAllRegisteredSetup/tpccmultidb took 9 minutes on CI with external process mode. I couldn't quickly speed that up (e.g. exempting from rate limiting didn't help), but skipping it will work just fine.

Epic: None
Release note: None


Release justification: test-only change.

We already skip `tpcc` in `bigInitialData`, and I think it was a mistake
that `tpccmultidb` wasn't marked in the same way. In particular, this
will make it so that we don't run some of the test cases.

The reason I was looking into this is that
`TestAllRegisteredSetup/tpccmultidb` took 9 minutes on CI with external
process mode. I couldn't quickly speed that up (e.g. exempting from rate
limiting didn't help), but skipping it will work just fine.

Release note: None
@yuzefovich yuzefovich force-pushed the blathers/backport-release-24.3-160209 branch from 611a3ad to 91e9efb Compare January 5, 2026 04:43
@yuzefovich yuzefovich requested a review from a team as a code owner January 5, 2026 04:43
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 5, 2026
@yuzefovich yuzefovich requested review from nameisbhaskar and shailendra-patel and removed request for a team January 5, 2026 04:43
@blathers-crl
Copy link

blathers-crl bot commented Jan 5, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot requested review from fqazi and williamchoe3 January 5, 2026 04:43
@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-queries SQL Queries Team labels Jan 5, 2026
@blathers-crl
Copy link

blathers-crl bot commented Jan 5, 2026

✅ PR #160453 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The PR involves a test-only change by modifying a file termed all_test.go, which is structured as a non-production file (matching '*_test.go'). This classification places the PR within the exemption granted by the CockroachDB backport policy for changes that solely affect non-production code. Moreover, the body of the PR includes a release justification explicitly stating it is a 'test-only change,' satisfying the condition that allows exemption from the typical critical bug justification and feature flag requirements.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich requested a review from srosenberg January 5, 2026 04:44
@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Jan 5, 2026
@yuzefovich yuzefovich merged commit 5a7cd37 into cockroachdb:release-24.3 Jan 5, 2026
17 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-24.3-160209 branch January 5, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-queries SQL Queries Team target-release-24.3.26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants