loqrecovery: enable DRPC for loqrecovery tests randomly #160456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
cthumuluru-crdb
force-pushed
the
issue-159372
branch
from
532a0fe to
e99a1bc
Compare
Nukitt
requested changes
Jan 7, 2026
cthumuluru-crdb
force-pushed
the
issue-159372
branch
from
e99a1bc to
3aeeca6
Compare
Nukitt
approved these changes
Jan 9, 2026
Contributor
|
LGTM! |
Previously, loqrecovery tests would fail when DRPC was enabled because DRPC returns codes.Unknown for connection errors, while gRPC returns codes.Unavailable. DRPC version used in this patch has a fix to return codes.Unavailable for connection errors. Fixes: cockroachdb#159372 Epic: CRDB-55382 Release note: None
cthumuluru-crdb
force-pushed
the
issue-159372
branch
from
3aeeca6 to
cd1e3f8
Compare
Contributor
Author
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, loqrecovery tests would fail when DRPC was enabled because DRPC returns codes.Unknown for connection errors, while gRPC returns codes.Unavailable. DRPC version used in this patch has a fix to return codes.Unavailable for connection errors.
Fixes: #159372
Epic: CRDB-55382
Release note: None