Skip to content

Conversation

@yuzefovich
Copy link
Member

I noticed that inspect tests were quite slow, so I added jobs.NewTestingKnobsWithShortIntervals() to all that start a server or a cluster, which significantly sped up things (from multiple minutes to under a minute when run sequentially).

Epic: None
Release note: None

I noticed that inspect tests were quite slow, so I added
`jobs.NewTestingKnobsWithShortIntervals()` to all that start a server or
a cluster, which significantly sped up things (from multiple minutes to
under a minute when run sequentially).

Release note: None
@yuzefovich yuzefovich requested review from bghal and spilchen January 7, 2026 04:26
@yuzefovich yuzefovich requested a review from a team as a code owner January 7, 2026 04:26
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich added backport-25.4.x Flags PRs that need to be backported to 25.4 backport-26.1.x Flags PRs that need to be backported to 26.1 labels Jan 7, 2026
Copy link
Contributor

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks for fixing this!

@spilchen reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @bghal).

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 7, 2026

@craig craig bot merged commit 1f49236 into cockroachdb:master Jan 7, 2026
24 of 25 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Jan 7, 2026

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 9987165 to blathers/backport-release-25.4-160588: POST https://api.github.com/repos/yuzefovich/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 25.4.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-25.4.x Flags PRs that need to be backported to 25.4 backport-26.1.x Flags PRs that need to be backported to 26.1 backport-failed target-release-26.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants