-
Notifications
You must be signed in to change notification settings - Fork 4.1k
release-26.1: sql: add distsql_prevent_partitioning_soft_limited_scans #160600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c5da417 to
37e13e0
Compare
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
Add a setting to the physical planner which prevents partitioning of soft-limited scans, to make them match hard-limited scans. This makes them lazier. Fixes: #160530 Release note (performance improvement): Add a new session variable, `distsql_prevent_partitioning_soft_limited_scans`, which, when true, prevents scans with soft limits from being planned as multiple TableReaders by the physical planner. This should decrease the initial setup costs of some fully-distributed query plans.
Release note (performance improvement): enable setting `distsql_prevent_partitioning_soft_limited_scans` by default.
37e13e0 to
03406ae
Compare
yuzefovich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd backport both commits to 26.1 right away, but up to you.
@yuzefovich reviewed 11 files and all commit messages, and made 1 comment.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball, @michae2, and @mw5h).
|
My argument for backporting both commits to 26.1 is the following:
|
michae2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good arguments. It does seem lower risk to enable it in 26.1.
@michae2 reviewed 11 files and all commit messages, and made 1 comment.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball and @mw5h).
Backport 2/2 commits from #160051 on behalf of @michae2.
sql: add distsql_prevent_partitioning_soft_limited_scans
Add a setting to the physical planner which prevents partitioning of soft-limited scans, to make them match hard-limited scans. This makes them lazier.
Fixes: #160530
Release note (performance improvement): Add a new session variable,
distsql_prevent_partitioning_soft_limited_scans, which, when true, prevents scans with soft limits from being planned as multiple TableReaders by the physical planner. This should decrease the initial setup costs of some fully-distributed query plans.sql: enable distsql_prevent_partitioning_soft_limited_scans by default
Release note (performance improvement): enable setting
distsql_prevent_partitioning_soft_limited_scansby default.Release justification: low-risk performance improvement.