Skip to content

kvnemesis: disable SQL ops in safety mode #160647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craig merged 1 commit into from
Jan 9, 2026
Merged

kvnemesis: disable SQL ops in safety mode #160647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/kv/kvnemesis/kvnemesis_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,11 @@ func TestKVNemesisMultiNode_Partition_Safety(t *testing.T) {
testGeneratorConfig: func(cfg *GeneratorConfig) {
cfg.Ops.Fault.AddNetworkPartition = 1
cfg.Ops.Fault.RemoveNetworkPartition = 1
// This is the only operation that executes via SQL. As such, we suspect
// context cancellations are not always respected, resulting in the test
// hanging. The current suspect is lib/pq. See #160293.
// TODO(mira): Consider toggling global reads by editing the span config.
cfg.Ops.ChangeZone.ToggleGlobalReads = 0
},
})
}
Expand Down