Skip to content

cmd/ghsearchdump: update search query to include date range #160655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wenyihu6 wants to merge 2 commits into
base: master
Choose a base branch
from
+180 −14
Open

cmd/ghsearchdump: update search query to include date range #160655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5e43fc
cmd/ghsearchdump: update search query to include date range
wenyihu6 Jan 7, 2026
d46f36b
cmd/ghsearchdump: improve prompt
wenyihu6 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions pkg/cmd/kv/ghsearchdump/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ func main() {
}

// Search for PRs.
prNumbers, err := searchItems(*searchQuery, "pr", *limit)
prNumbers, err := searchItems(*searchQuery, "pr", *limit, contribAfter, contribBefore)
if err != nil {
fmt.Fprintf(os.Stderr, "error searching PRs: %v\n", err)
os.Exit(1)
Expand Down Expand Up @@ -236,7 +236,7 @@ func main() {

// Search for issues if requested.
if *includeIssues {
issueNumbers, err := searchItems(*searchQuery, "issue", *limit)
issueNumbers, err := searchItems(*searchQuery, "issue", *limit, contribAfter, contribBefore)
if err != nil {
fmt.Fprintf(os.Stderr, "error searching issues: %v\n", err)
os.Exit(1)
Expand Down Expand Up @@ -297,11 +297,29 @@ func extractAuthors(query string) []string {
return authors
}

func searchItems(query string, itemType string, limit int) ([]int, error) {
func searchItems(query string, itemType string, limit int, after, before time.Time) ([]int, error) {
// Use gh api directly because `gh search prs` with multiple --author flags
// AND's them together instead of OR'ing them like the web UI does.
fullQuery := query + " is:" + itemType

// Apply API-level date filtering with care to avoid data loss.
//
// GitHub's "updated:" field captures ANY activity (comments, labels, reviews),
// while our contribution dates track specific events (pushes for PRs, tracked
// author activity for issues). Since updated >= contribution (always), we can
// safely use "updated:>=after" as an optimization.
//
// For the upper bound, we use "created:<before" which filters by when the PR/issue
// was opened. Note: This may exclude PRs where commits were pushed before the cutoff
// but the PR was created after (e.g., commits on a branch, PR opened later). This is
// an acceptable trade-off for reducing API results.
if !after.IsZero() {
fullQuery += fmt.Sprintf(" updated:>=%s", after.Format("2006-01-02"))
}
if !before.IsZero() {
fullQuery += fmt.Sprintf(" created:<%s", before.Format("2006-01-02"))
}

var allNumbers []int
page := 1
perPage := 100
Expand Down
Loading
Loading