scheduledlogging: use stopper.WithCancelOnQuiesce for CaptureIndexUsageStats #160656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geStats This commit ensures that inflight captureIndexUsageStats will not block node shutdown. Fixes: cockroachdb#160117 Release note: None
alyshanjahani-crl
requested review from
jasonlmfong
and removed request for
a team
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Collaborator
Author
|
Closing in favour of more general solution #160658 |
rafiss
reviewed
Jan 8, 2026
Collaborator
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
this seems like a good idea to keep. there's no reason not do this, and keeping it provides defense-in-depth in case there's another spot where we missed a context cancellation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that inflight captureIndexUsageStats will not block node shutdown.
Fixes: #160117
Release note: None