release-25.4: persistedsqlstats: add WithCancelOnQuiesce to MaybeFlushWithDrainer#161177
Conversation
use context from stopper.WithCancelOnQuiesce(ctx) to prevent slow slow quiesce during shutdown Epic: None Fixes: cockroachdb#159467 Release note: None
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
✅ PR #161177 is compliant with backport policy Confidence: high 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Backport 1/1 commits from #160403.
/cc @cockroachdb/release
use context from stopper.WithCancelOnQuiesce(ctx) to prevent slow slow quiesce during shutdown
Epic: None
Fixes: #159467
Release note: None
Release Justification: Low risk change that prevents slow quiesce during shutdowns. This has been seen in 25.4 (#161060), so we are backporting.