release-26.1: tree: walk all of Insert, Delete, and Update#161970
Merged
michae2 merged 1 commit intorelease-26.1from Jan 29, 2026
Merged
release-26.1: tree: walk all of Insert, Delete, and Update#161970michae2 merged 1 commit intorelease-26.1from
michae2 merged 1 commit intorelease-26.1from
Conversation
blathers-crl
bot
force-pushed
the
blathers/backport-release-26.1-161773
branch
from
ff28d8d to
bfeee76
Compare
blathers-crl
bot
requested review from
ZhouXing19
and removed request for
a team
blathers-crl
bot
added
blathers-backport
Author
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
Member
|
This change is |
yuzefovich
approved these changes
Jan 28, 2026
Member
yuzefovich
left a comment
yuzefovich
left a comment
There was a problem hiding this comment.
@yuzefovich reviewed 3 files and all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball, @michae2, and @ZhouXing19).
Teach ExtendedVisitor to walk all of Insert, Delete, and Update AST nodes. This allows hint injection for mutation statements. Fixes: #161729 Release note (bug fix): Fix a bug which prevented successfully injecting hints using `information_schema.crdb_rewrite_inline_hints` for INSERT, UPSERT, UPDATE, and DELETE statements. This bug has existed since hint injection was introduced in v26.1.0-alpha.2. Co-Authored-By: Claude <noreply@anthropic.com>
michae2
force-pushed
the
blathers/backport-release-26.1-161773
branch
from
bfeee76 to
2fce783
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #161773 on behalf of @michae2.
Teach ExtendedVisitor to walk all of Insert, Delete, and Update AST nodes. This allows hint injection for mutation statements.
Fixes: #161729
Release note (bug fix): Fix a bug which prevented successfully injecting hints using
information_schema.crdb_rewrite_inline_hintsfor INSERT, UPSERT, UPDATE, and DELETE statements. This bug has existed since hint injection was introduced in v26.1.0-alpha.2.Release justification: fix for GA blocker in new functionality.