Skip to content

release-25.2: kvcoord: make kv.transaction.write_buffering.enabled non-public#162002

Merged
michae2 merged 1 commit intocockroachdb:release-25.2from
stevendanna:ssd/non-public-25.2
Jan 29, 2026
Merged

release-25.2: kvcoord: make kv.transaction.write_buffering.enabled non-public#162002
michae2 merged 1 commit intocockroachdb:release-25.2from
stevendanna:ssd/non-public-25.2

Conversation

@stevendanna
Copy link
Collaborator

@stevendanna stevendanna commented Jan 29, 2026

This feature should likely only be used in newer release, removing it from the list of cluster settings makes it more clear.

Epic: None
Release note (doc change): kv.transaction.write_buffering.enabled is removed from the public cluster settings to better reflect its preview status.

Release justification: docs change.

This feature should likely only be used in newer release, removing it from the
list of cluster settings makes it more clear.

Epic: None
Release note (doc change): `kv.transaction.write_buffering.enabled` is removed
from the public cluster settings to better reflect its preview status.
@stevendanna stevendanna requested a review from a team as a code owner January 29, 2026 11:44
@blathers-crl
Copy link

blathers-crl bot commented Jan 29, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-cli labels Jan 29, 2026
@blathers-crl
Copy link

blathers-crl bot commented Jan 29, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Jan 29, 2026

✅ PR #162002 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The PR makes a change to a cluster setting but does it in a manner consistent with a disabled feature flag. Specifically, the PR's code changes to 'pkg/kv/kvclient/kvcoord/txn_interceptor_write_buffer.go' involve removing the public availability flags from the 'kv.transaction.write_buffering.enabled' and related settings. This makes these settings non-public and enforces their default state as disabled. Moreover, the PR claims to only be a documentation adjustment, aligning with a scenario where the feature-setting remains essentially unchanged but is merely hidden from public API, hence not affecting functionality or backport compatibility negatively.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@yuzefovich yuzefovich changed the title kvcoord: make kv.transaction.write_buffering.enabled non-public release-25.2: kvcoord: make kv.transaction.write_buffering.enabled non-public Jan 29, 2026
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuzefovich reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @stevendanna).

@michae2 michae2 merged commit c71d108 into cockroachdb:release-25.2 Jan 29, 2026
19 checks passed
@michae2
Copy link
Collaborator

michae2 commented Jan 29, 2026

blathers backport release-25.2.12-rc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-cli target-release-25.2.13

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants