roachtest: eliminate Docker from db-console Cypress tests#164000
Open
dhartunian wants to merge 1 commit intocockroachdb:masterfrom
Open
roachtest: eliminate Docker from db-console Cypress tests#164000dhartunian wants to merge 1 commit intocockroachdb:masterfrom
dhartunian wants to merge 1 commit intocockroachdb:masterfrom
Conversation
The db-console/cypress, db-console/cypress-pages, and db-console/mixed-version-cypress roachtests flake consistently due to Docker installation failures (apt-get for Docker's third-party repo) and Docker image build timeouts (pulling ~2GB cypress/included image). Replace Docker with direct Cypress execution on the workload node: - Add installNode22() to javascript_helpers.go for Node.js 22.14.0 LTS with pnpm support, following the existing installNode18 pattern. - Rewrite dbConsoleCypressTest to install Node.js, pnpm, Cypress system libraries (from Ubuntu's default repos), and npm dependencies directly on the workload node instead of building a Docker image. - Replace `docker run` with direct `npx cypress run` invocation. - Delete the Dockerfile and its BUILD.bazel embed reference. Fixes: cockroachdb#163910 Fixes: cockroachdb#163476 Fixes: cockroachdb#163480 Fixes: cockroachdb#163510 Fixes: cockroachdb#163483 Release note: None
dhartunian
added
backport-25.2.x
Contributor
|
Merging to
|
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The db-console/cypress, db-console/cypress-pages, and db-console/mixed-version-cypress roachtests flake consistently due to Docker installation failures (apt-get for Docker's third-party repo) and Docker image build timeouts (pulling ~2GB cypress/included image).
Replace Docker with direct Cypress execution on the workload node:
docker runwith directnpx cypress runinvocation.Fixes: #163910
Fixes: #163476
Fixes: #163480
Fixes: #163510
Fixes: #163483
Release note: None