crhumanize: improve API and revamp implementation#17
Merged
RaduBerinde merged 2 commits intocockroachdb:mainfrom Jun 17, 2025
Merged
crhumanize: improve API and revamp implementation#17RaduBerinde merged 2 commits intocockroachdb:mainfrom
RaduBerinde merged 2 commits intocockroachdb:mainfrom
Conversation
Add a copy of datadriven so we can use it for internal tests (we don't want crlib to have any external dependencies).
RaduBerinde
force-pushed
the
cr-humanize-more-work
branch
from
f2533f5 to
4578448
Compare
jbowens
approved these changes
Jun 17, 2025
Contributor
jbowens
left a comment
jbowens
left a comment
There was a problem hiding this comment.
Reviewed 19 of 26 files at r1, all commit messages.
Reviewable status: 19 of 26 files reviewed, all discussions resolved
Member
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal: add datadriven
Add a copy of datadriven so we can use it for internal tests (we don't
want crlib to have any external dependencies).
crhumanize: improve API and revamp implementation
This change is