Merged
Conversation
Add an overflow-safe scaling function.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new overflow-safe scaling function ScaleUint64 to the crmath package that computes the ceiling of x*a/b while handling potential overflow conditions safely.
- Implements
ScaleUint64function with optimized fast path for smaller values and overflow protection - Includes comprehensive test coverage with edge cases, randomized testing, and verification against big.Int implementation
- Handles division by zero with panic behavior and overflow cases by clamping to
math.MaxUint64
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crmath/scale.go | Implements the main ScaleUint64 function with fast/slow path optimization and overflow handling |
| crmath/scale_test.go | Comprehensive test suite including edge cases, randomized testing, and panic verification |
Member
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an overflow-safe scaling function.
This change is