Skip to content

ci: remove test_area_lookups from expected failures #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timgraham merged 1 commit into from
May 22, 2025
Merged

ci: remove test_area_lookups from expected failures #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions django_cockroachdb_gis/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from django.contrib.gis.db.backends.postgis.features import (
DatabaseFeatures as PostGISFeatures,
)
from django.db.backends.postgresql.psycopg_any import is_psycopg3
from django.utils.functional import cached_property

from django_cockroachdb.features import DatabaseFeatures as CockroachFeatures
Expand Down Expand Up @@ -74,15 +73,6 @@ def django_test_expected_failures(self):
# https://github.com/cockroachdb/cockroach/issues/47420#issuecomment-969578772
'gis_tests.gis_migrations.test_operations.OperationTests.test_add_3d_field_opclass',
})
if is_psycopg3 and not self.is_cockroachdb_24_1:
expected_failures.update({
# QuerySet.bulk_create() doesn't work with geometries after
# https://github.com/django/django/commit/a16eedcf9c69d8a11d94cac1811018c5b996d491
# could not parse geometry: error parsing EWKB hex: encoding/hex:
# invalid byte: U+003A ':'
# https://github.com/cockroachdb/cockroach/issues/138140
'gis_tests.geoapp.test_functions.GISFunctionsTests.test_area_lookups',
})
if self.uses_server_side_binding:
expected_failures.update({
# unknown signature: st_scale(geometry, int, int)
Expand Down