-
Notifications
You must be signed in to change notification settings - Fork 477
Document patch deferral for CC and CCAPI #20871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments and tagged @VishalJaishankar in some questions about the API behavior 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-read the API code to answer some questions I had before to un-block this PR. The patch deferral stuff looks good to me, just left 1 comment to remove FIXED_DEFERRAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment on the clarity of one sentence (which I think existed before). Otherwise, removing passive language in the instructions.
| Where: | ||
|
|
||
| - `{cluster_id}` is the unique ID of this cluster. | ||
| {{site.data.alerts.callout_info}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this block needs to be indented to align with the bullet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Ryan Kuo <[email protected]>

https://cockroachlabs.atlassian.net/browse/DOC-13043
https://cockroachlabs.atlassian.net/browse/DOC-13042