Use the GODEBUG env var to disable Transparent Huge Pages#463
Merged
MattWhelan merged 2 commits intocockroachdb:masterfrom Feb 28, 2025
Merged
Use the GODEBUG env var to disable Transparent Huge Pages#463MattWhelan merged 2 commits intocockroachdb:masterfrom
MattWhelan merged 2 commits intocockroachdb:masterfrom
Conversation
pritesh-lahoti
approved these changes
Feb 28, 2025
Contributor
pritesh-lahoti
left a comment
pritesh-lahoti
left a comment
There was a problem hiding this comment.
Thank you for the changes!
Comment on lines
+263
to
+269
| {{- define "godebugList" -}} | ||
| {{- $godebugList := list -}} | ||
| {{- range $key, $value := .Values.godebug }} | ||
| {{- $godebugList = append $godebugList (printf "%s=%s" $key $value) -}} | ||
| {{- end }} | ||
| {{- join "," $godebugList -}} | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
This could move to cockroachdb/templates/_helpers.tpl.
prafull01
pushed a commit
to prafull01/helm-charts
that referenced
this pull request
Mar 11, 2025
…b#463) THP is unhelpful for databases, in general, because memory access tends to be non-contiguous, and the use of THP can make performance worse when it requires a bunch of page defragmentation to load and map a huge page. We now disable it by default, using the GODEBUG environment variable. Adds a generic facility for managing GODEBUG clauses to the Helm chart. closes https://cockroachlabs.atlassian.net/browse/TREQ-888
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THP is unhelpful for databases, in general, because memory access tends to be non-contiguous, and the use of THP can make performance worse when it requires a bunch of page defragmentation to load and map a huge page.
We disable it by default, using the GODEBUG environment variable.
Adds a generic facility for managing GODEBUG clauses to the Helm chart.
closes https://cockroachlabs.atlassian.net/browse/TREQ-888