[CRDB-48126] Added Operator charts, modified CockroachDB charts to support cc-operator#468
Conversation
cockroachdb/templates/_helpers.tpl
Outdated
| {{- join "," $godebugList -}} | ||
| {{- end }} | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: could we indent the changes appropriately?
There was a problem hiding this comment.
I don't think this has been addressed here and in operator/templates/_helpers.tpl.
There was a problem hiding this comment.
One commit changes got missed while doing reset, fixed all of them now
| {{- end }} | ||
| features: | ||
| - reconcile | ||
| - reconcile-beta |
There was a problem hiding this comment.
Most likely, we don't need this feature. Could you confirm?
There was a problem hiding this comment.
@jmcarp I see the reconcile-beta feature is added for migrating tests, can we remove this here?
cockroachdb/templates/crdb.yaml
Outdated
| # All properties below are solely to pass validation. They aren't used by the | ||
| # betaclusterctrl controller so the values don't matter so long as they're | ||
| # valid. |
There was a problem hiding this comment.
nit: we could update this comment.
There was a problem hiding this comment.
These things are from managed service template, @jmcarp We can remove this comment entirely right?
NishanthNalluri
force-pushed
the
nishanth/cc-operator-charts
branch
from
8761ba8 to
218ad19
Compare
cockroachdb/templates/_helpers.tpl
Outdated
| {{- join "," $godebugList -}} | ||
| {{- end }} | ||
|
|
||
|
|
There was a problem hiding this comment.
I don't think this has been addressed here and in operator/templates/_helpers.tpl.
NishanthNalluri
force-pushed
the
nishanth/cc-operator-charts
branch
2 times, most recently
from
9c9fafd to
f68a938
Compare
| # A map of CRDB cluster settings. | ||
| # See https://www.cockroachlabs.com/docs/stable/cluster-settings.html | ||
| clusterSettings: ~ | ||
|
|
There was a problem hiding this comment.
nit:
NishanthNalluri
force-pushed
the
nishanth/cc-operator-charts
branch
from
a6259c7 to
14d1ec5
Compare
Fix: e2e test cases Fix: e2e test cases
NishanthNalluri
force-pushed
the
nishanth/cc-operator-charts
branch
from
bba2070 to
cee35d2
Compare
NishanthNalluri
changed the title
| kind: ClusterRole | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| metadata: | ||
| name: {{ template "cockroachdb.fullname" . }}-node-reader | ||
| namespace: {{ .Release.Namespace | quote }} |
There was a problem hiding this comment.
| kind: ClusterRole | |
| apiVersion: rbac.authorization.k8s.io/v1 | |
| metadata: | |
| name: {{ template "cockroachdb.fullname" . }}-node-reader | |
| namespace: {{ .Release.Namespace | quote }} | |
| kind: ClusterRole | |
| apiVersion: rbac.authorization.k8s.io/v1 | |
| metadata: | |
| name: {{ template "cockroachdb.clusterfullname" . }}-node-reader |
- This ClusterRole is causing issues (see Issue Error "Unable to create ClusterRole" if two releases with same releasename in different namespaces #283). Please remove any namespace declaration and ensure its name is globally unique.
There was a problem hiding this comment.
Thanks for letting us know, we've fixed this issue and released a new version 16.0.4. Please feel free to upgrade and let us know, if you face any issues.
4 participants
Prev PR's: [#456] [#455]
JIRA: [CRDB-48126]
Parent: [CRDB-43233]