Skip to content

Fix lack of labelSelector for cockroachDB #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kylepl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix lack of labelSelector for cockroachDB #584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83aad99
I recently discovered that if you do not set a labelSelector, it seem…
kylepl Dec 17, 2025
4aadcb2
Change to crdb.cockroachlabs.com/cluster.
kylepl Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cockroachdb-parent/charts/cockroachdb/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,9 @@ cockroachdb:
topologyKey: topology.kubernetes.io/zone
# whenUnsatisfiable defines the behavior when constraints cannot be met.
whenUnsatisfiable: DoNotSchedule
labelSelector:
matchLabels:
crdb.cockroachlabs.com/cluster: cockroachdb
Copy link
Contributor

@NishanthNalluri NishanthNalluri Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label value will not always be cockroachdb. The value needs to be "{{ template \"cockroachdb.fullname\" . }}", similar to the CR name.

Copy link
Author

@kylepl kylepl Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that.

To confirm, do you want the value of the row to be exactly:
crdb.cockroachlabs.com/cluster: cockroachdb: "{{ template \"cockroachdb.fullname\" . }}"

Not the quotations. I ask since I'm not sure how template evaluation works for things in values.yaml (rather than things in templates/) - and I don't see any examples of it in the same values.yaml file.

Copy link
Contributor

@NishanthNalluri NishanthNalluri Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that should work, you can test it out once by rendering templates.

# # terminationGracePeriodSeconds determines the time available to CockroachDB for graceful drain.
# terminationGracePeriodSeconds: 300
# # tolerations captures the tolerations for pods of the self-signer job.
Expand Down