-
Notifications
You must be signed in to change notification settings - Fork 514
db: add metric encapsulating blob file rewrite bytes read, written #5525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumeerbhola reviewed 8 of 9 files at r1.
Reviewable status: 8 of 9 files reviewed, 3 unresolved discussions
-- commits line 4 at r1:
independent of the level?
testdata/compaction/value_separation line 546 at r1 (raw file):
est. debt | in progress | cancelled | failed | problem spans | read | written --------------+---------------+------------+----------+------------------+------------+----------- 0B | 0 (0B) | 0 (0B) | 0 | 0 | 83B | 150B
why is the read smaller than the written?
blob_rewrite.go line 251 at r1 (raw file):
// rewrites don't contribute to per-level compacted bytes. // Count blob value blocks read from the blob file during the rewrite. bytesRead := c.internalIteratorStats.BlockReads[blockkind.BlobValue].BlockBytes
Is this why we bytes read could be smaller, because we don't count the various meta blocks or properties etc., while the write path does? Which is fine.
7ad4823 to
0f5721c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 8 of 9 files reviewed, 3 unresolved discussions (waiting on @sumeerbhola)
Previously, sumeerbhola wrote…
independent of the level?
yes; corrected wording!
blob_rewrite.go line 251 at r1 (raw file):
Previously, sumeerbhola wrote…
Is this why we bytes read could be smaller, because we don't count the various meta blocks or properties etc., while the write path does? Which is fine.
yes - i'll add a comment for this as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumeerbhola reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @annrpom)
Blob file rewrite compactions happen independent of LSM levels, and so don't contribute to the per-level 'compacted bytes' total. This patch adds separate metrics recording the bytes read and bytes written during these compactions. Fixes: cockroachdb#5444
0f5721c to
10f71d3
Compare
|
TFTR! ('-')7 |
Blob file rewrite compactions happen independent of LSM levels, and so don't
contribute to the per-level 'compacted bytes' total. This patch adds separate
metrics recording the bytes read and bytes written during these compactions.
Fixes: #5444