Conversation
cococonscious
left a comment
cococonscious
left a comment
There was a problem hiding this comment.
Thanks for the PR! It looks good overall, there's just some minor things I'd like to be different.
| pub autocomplete: bool, | ||
| pub breaking_changes: bool, | ||
| pub commit_types: IndexMap<String, CommitType>, | ||
| pub commit_scopes: IndexMap<String, CommitScope>, |
There was a problem hiding this comment.
Please isolate the changes to the configuration from the gix support, as #161 is already introducing that feature.
This also applies to the other references to configurable commit scopes of course.
| temp_dir: &std::path::Path, | ||
| message: &'static str, | ||
| ) -> Result<(), Box<dyn Error>> { | ||
| Command::new("git") |
There was a problem hiding this comment.
I'm not a huge fan of running system commands if there is a way to do it programmatically, can you try to implement it with gix?
| assert_cmd = "2.0.16" | ||
| predicates = "3.1.2" | ||
| tempfile = "3.12.0" | ||
| rusty-hook = "^0.11.2" |
There was a problem hiding this comment.
I replaced rusty-hook with prek recently as the former seems abandoned, please remove the dependency.
There was a problem hiding this comment.
Odd, it was forcing me to install it to commit... is prek a drop-in?
There was a problem hiding this comment.
No, I don't think so, prek is a drop-in for pre-commit
| for info in walk.all()? { | ||
| let info = info?; | ||
|
|
||
| // Get the commit object |
There was a problem hiding this comment.
These comments seem quite redundant since the code is very readable in my opinion.
There was a problem hiding this comment.
Haha they totally are, just included them to help me work through the conversion
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
2 participants
No description provided.