Skip to content

fix(lancedb): use fixed size list for vector #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgeh0 merged 1 commit into from
Sep 23, 2025
Merged

fix(lancedb): use fixed size list for vector #1034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/cocoindex/targets/lancedb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,10 @@ def _convert_basic_type_to_pa_type(basic_type: BasicValueType) -> pa.DataType:
raise ValueError("Vector type missing vector schema")
element_type = _convert_basic_type_to_pa_type(vector_schema.element_type)

# Create list type with the element type
return pa.list_(element_type)
if vector_schema.dimension is not None:
return pa.list_(element_type, vector_schema.dimension)
else:
return pa.list_(element_type)

if kind == "Range":
# Range as a struct with start and end
Expand Down
Loading